diff options
| author | Keir Fraser <keir.fraser@citrix.com> | 2009-04-17 13:07:06 +0100 |
|---|---|---|
| committer | Keir Fraser <keir.fraser@citrix.com> | 2009-04-17 13:07:06 +0100 |
| commit | cebd2137ea64a8ba9cc2edc57df556224917e9bd (patch) | |
| tree | 3cc19abf0faab15d7237c1df224a098cb99b3cbe | |
| parent | 9d09f146c9bce443acd32852ccb1722b0d2cbc4b (diff) | |
| download | xen-cebd2137ea64a8ba9cc2edc57df556224917e9bd.tar.gz xen-cebd2137ea64a8ba9cc2edc57df556224917e9bd.tar.bz2 xen-cebd2137ea64a8ba9cc2edc57df556224917e9bd.zip | |
x86: avoid EPT scanning errors when splitting superpages during live migration
Since Xen did not lock the p2m table for p2m table reading, when
splitting the large page during live migration, we should make sure
the path of EPT entries be modified are always there while other CPUs
may access the super entries at the same time.
Signed-off-by: Xin, Xiaohui <xiaohui.xin@intel.com>
| -rw-r--r-- | xen/arch/x86/mm/hap/p2m-ept.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xen/arch/x86/mm/hap/p2m-ept.c b/xen/arch/x86/mm/hap/p2m-ept.c index bb1e8ee643..2531132187 100644 --- a/xen/arch/x86/mm/hap/p2m-ept.c +++ b/xen/arch/x86/mm/hap/p2m-ept.c @@ -210,17 +210,18 @@ ept_set_entry(struct domain *d, unsigned long gfn, mfn_t mfn, ept_entry_t *split_ept_entry = NULL; unsigned long split_mfn = ept_entry->mfn; p2m_type_t split_p2mt = ept_entry->avail1; + ept_entry_t new_ept_entry; /* alloc new page for new ept middle level entry which is * before a leaf super entry */ - if ( !ept_set_middle_entry(d, ept_entry) ) + if ( !ept_set_middle_entry(d, &new_ept_entry) ) goto out; /* split the super page before to 4k pages */ - split_table = map_domain_page(ept_entry->mfn); + split_table = map_domain_page(new_ept_entry.mfn); offset = gfn & ((1 << EPT_TABLE_ORDER) - 1); for ( i = 0; i < 512; i++ ) @@ -257,6 +258,7 @@ ept_set_entry(struct domain *d, unsigned long gfn, mfn_t mfn, ept_p2m_type_to_flags(split_ept_entry, p2mt); unmap_domain_page(split_table); + *ept_entry = new_ept_entry; } /* Track the highest gfn for which we have ever had a valid mapping */ |