aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkaf24@firebug.cl.cam.ac.uk <kaf24@firebug.cl.cam.ac.uk>2006-10-06 08:09:52 +0100
committerkaf24@firebug.cl.cam.ac.uk <kaf24@firebug.cl.cam.ac.uk>2006-10-06 08:09:52 +0100
commit2eb4f7a7dfd302d945a87c1f4bc0f98ef21ec1e2 (patch)
tree1bece8c08692ed5942aa5f7a8a7ac48c54dab685
parentf58fdb8d020c1b6cce3728986812cdd25eb016fe (diff)
downloadxen-2eb4f7a7dfd302d945a87c1f4bc0f98ef21ec1e2.tar.gz
xen-2eb4f7a7dfd302d945a87c1f4bc0f98ef21ec1e2.tar.bz2
xen-2eb4f7a7dfd302d945a87c1f4bc0f98ef21ec1e2.zip
[HVM][SVM] Revert changeset 11679:a949bd6ceb85
Although in the correct spirit, it seems there is some other dependency in the code that assumes ExtInts are queued until thay can be immediately delivered (EFLAGS.IF==1). This patch therefore caused instability in Linux guests. Signed-off-by: Keir Fraser <keir@xensource.com>
-rw-r--r--xen/arch/x86/hvm/svm/intr.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c
index 063e919cb3..0f30bd5478 100644
--- a/xen/arch/x86/hvm/svm/intr.c
+++ b/xen/arch/x86/hvm/svm/intr.c
@@ -74,6 +74,7 @@ asmlinkage void svm_intr_assist(void)
int intr_type = APIC_DM_EXTINT;
int intr_vector = -1;
int re_injecting = 0;
+ unsigned long rflags;
ASSERT(vmcb);
@@ -86,6 +87,14 @@ asmlinkage void svm_intr_assist(void)
re_injecting = 1;
}
+ /* Guest's interrputs masked? */
+ rflags = vmcb->rflags;
+ if (irq_masked(rflags)) {
+ HVM_DBG_LOG(DBG_LEVEL_1, "Guest IRQs masked: rflags: %lx", rflags);
+ /* bail out, we won't be injecting an interrupt this time */
+ return;
+ }
+
/* Previous interrupt still pending? */
if (vmcb->vintr.fields.irq) {
// printk("Re-injecting IRQ from Vintr\n");