1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
|
From e14032e74f63afc123d631d4475b057221b2de60 Mon Sep 17 00:00:00 2001
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
Date: Thu, 11 Jun 2020 18:19:13 +0100
Subject: [PATCH] media: i2c: imx290: Add exposure control to the
driver.
Adds support for V4L2_CID_EXPOSURE so that userspace can control
the sensor exposure time.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/imx290.c | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -45,6 +45,10 @@ enum imx290_clk_index {
#define IMX290_HMAX_MIN_2LANE 4400 /* Min of 4400 pixels = 30fps */
#define IMX290_HMAX_MIN_4LANE 2200 /* Min of 2200 pixels = 60fps */
#define IMX290_HMAX_MAX 0xffff
+
+#define IMX290_EXPOSURE_MIN 2
+#define IMX290_EXPOSURE_STEP 1
+#define IMX290_EXPOSURE_LOW 0x3020
#define IMX290_PGCTRL 0x308c
#define IMX290_PHY_LANE_NUM 0x3407
#define IMX290_CSI_LANE_MODE 0x3443
@@ -103,6 +107,7 @@ struct imx290 {
struct v4l2_ctrl *pixel_rate;
struct v4l2_ctrl *hblank;
struct v4l2_ctrl *vblank;
+ struct v4l2_ctrl *exposure;
struct mutex lock;
};
@@ -529,6 +534,20 @@ static int imx290_set_gain(struct imx290
return ret;
}
+static int imx290_set_exposure(struct imx290 *imx290, u32 value)
+{
+ u32 exposure = (imx290->current_mode->height + imx290->vblank->val) -
+ value;
+ int ret;
+
+ ret = imx290_write_buffered_reg(imx290, IMX290_EXPOSURE_LOW, 3,
+ exposure);
+ if (ret)
+ dev_err(imx290->dev, "Unable to write exposure\n");
+
+ return ret;
+}
+
static int imx290_set_hmax(struct imx290 *imx290, u32 val)
{
u32 hmax = val + imx290->current_mode->width;
@@ -590,6 +609,9 @@ static int imx290_set_ctrl(struct v4l2_c
case V4L2_CID_GAIN:
ret = imx290_set_gain(imx290, ctrl->val);
break;
+ case V4L2_CID_EXPOSURE:
+ ret = imx290_set_exposure(imx290, ctrl->val);
+ break;
case V4L2_CID_HBLANK:
ret = imx290_set_hmax(imx290, ctrl->val);
break;
@@ -764,6 +786,12 @@ static int imx290_set_fmt(struct v4l2_su
IMX290_VMAX_MAX - mode->height,
1,
mode->vmax - mode->height);
+ if (imx290->exposure)
+ __v4l2_ctrl_modify_range(imx290->exposure,
+ mode->vmax - mode->height,
+ mode->vmax - 4,
+ IMX290_EXPOSURE_STEP,
+ mode->vmax - 4);
}
*format = fmt->format;
@@ -1178,6 +1206,13 @@ static int imx290_probe(struct i2c_clien
IMX290_VMAX_MAX - mode->height, 1,
mode->vmax - mode->height);
+ imx290->exposure = v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
+ V4L2_CID_EXPOSURE,
+ IMX290_EXPOSURE_MIN,
+ mode->vmax - 4,
+ IMX290_EXPOSURE_STEP,
+ mode->vmax - 4);
+
imx290->link_freq =
v4l2_ctrl_new_int_menu(&imx290->ctrls, &imx290_ctrl_ops,
V4L2_CID_LINK_FREQ,
|
