From c38a34a4f9465df9bfeff355772555efa0cd574b Mon Sep 17 00:00:00 2001 From: 6by9 <6by9@users.noreply.github.com> Date: Tue, 11 Dec 2018 15:18:02 +0000 Subject: [PATCH 290/725] staging: bcm2835-camera: Check the error for REPEAT_SEQ_HEADER (#2782) When handling for V4L2_CID_MPEG_VIDEO_REPEAT_SEQ_HEADER was added the firmware would reject the setting if H264 hadn't already been selected. This was fixed in the firmware at that point, but to enable backwards compatibility the returned error was ignored. That was Dec 2013, so the chances of having a firmware that still has that issue is so close to zero that the workaround can be removed. Signed-off-by: Dave Stevenson --- drivers/staging/vc04_services/bcm2835-camera/controls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -1100,7 +1100,7 @@ static const struct bm2835_mmal_v4l2_ctr 0, 1, NULL, MMAL_PARAMETER_VIDEO_ENCODE_INLINE_HEADER, &ctrl_set_video_encode_param_output, - true /* Errors ignored as requires latest firmware to work */ + false }, { V4L2_CID_MPEG_VIDEO_H264_PROFILE,