From 482c85c7fc95c572d368b2214b9e9d2c4a2e5789 Mon Sep 17 00:00:00 2001 From: Matthew Hagan Date: Wed, 23 Feb 2022 23:50:40 +0000 Subject: [PATCH] ARM: dts: NSP: MX6X: correct LED function types Currently, the amber LED will remain always on. This is due to a misinterpretation of the LED sub-node properties, where-by "default-state" was used to indicate the initial state when powering on the device. When in use, however, this resulted in the amber LED always being on. Instead change this to only indicate a fault state. Assign LED_FUNCTION_POWER to the green PWM LED. These changes bring the MX64/65 in line with the MR32's devicetree. Signed-off-by: Matthew Hagan Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 3 +-- arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi | 3 +-- arch/arm/boot/dts/bcm958625-meraki-mx6x-common.dtsi | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) --- a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi +++ b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi @@ -57,10 +57,9 @@ led-4 { /* amber:power */ - function = LED_FUNCTION_POWER; + function = LED_FUNCTION_FAULT; color = ; gpios = <&gpioa 3 GPIO_ACTIVE_HIGH>; - default-state = "on"; }; led-5 { --- a/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi +++ b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi @@ -106,10 +106,9 @@ led-a { /* amber:power */ - function = LED_FUNCTION_POWER; + function = LED_FUNCTION_FAULT; color = ; gpios = <&gpioa 0 GPIO_ACTIVE_LOW>; - default-state = "on"; }; led-b { --- a/arch/arm/boot/dts/bcm958625-meraki-mx6x-common.dtsi +++ b/arch/arm/boot/dts/bcm958625-meraki-mx6x-common.dtsi @@ -22,7 +22,7 @@ }; led-2 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_POWER; color = ; pwms = <&pwm 2 50000>; max-brightness = <255>;