From ee513338448ddbb72ac8f76e7053865fe926a18c Mon Sep 17 00:00:00 2001 From: j-schambacher Date: Mon, 27 Jan 2020 20:37:34 +0100 Subject: [PATCH] adds LED OFF feature to HiFiBerry DAC+ADC sound card This adds a DT overlay parameter 'leds_off' which allows to switch off the onboard activity LEDs at all times which has been requested by some users. Signed-off-by: Joerg Schambacher --- arch/arm/boot/dts/overlays/README | 2 ++ .../boot/dts/overlays/hifiberry-dacplusadc-overlay.dts | 1 + sound/soc/bcm/hifiberry_dacplusadc.c | 10 +++++++++- 3 files changed, 12 insertions(+), 1 deletion(-) --- a/arch/arm/boot/dts/overlays/README +++ b/arch/arm/boot/dts/overlays/README @@ -927,6 +927,8 @@ Params: 24db_digital_gain Allow ga that does not result in clipping/distortion!) slave Force DAC+ Pro into slave mode, using Pi as master for bit clock and frame clock. + leds_off If set to 'true' the onboard indicator LEDs + are switched off at all times. Name: hifiberry-dacplusadcpro --- a/arch/arm/boot/dts/overlays/hifiberry-dacplusadc-overlay.dts +++ b/arch/arm/boot/dts/overlays/hifiberry-dacplusadc-overlay.dts @@ -67,5 +67,6 @@ 24db_digital_gain = <&hifiberry_dacplusadc>,"hifiberry,24db_digital_gain?"; slave = <&hifiberry_dacplusadc>,"hifiberry-dacplusadc,slave?"; + leds_off = <&hifiberry_dacplusadc>,"hifiberry-dacplusadc,leds_off?"; }; }; --- a/sound/soc/bcm/hifiberry_dacplusadc.c +++ b/sound/soc/bcm/hifiberry_dacplusadc.c @@ -54,6 +54,7 @@ struct pcm512x_priv { static bool slave; static bool snd_rpi_hifiberry_is_dacpro; static bool digital_gain_0db_limit = true; +static bool leds_off; static void snd_rpi_hifiberry_dacplusadc_select_clk(struct snd_soc_component *component, int clk_id) @@ -175,7 +176,10 @@ static int snd_rpi_hifiberry_dacplusadc_ snd_soc_component_update_bits(component, PCM512x_GPIO_EN, 0x08, 0x08); snd_soc_component_update_bits(component, PCM512x_GPIO_OUTPUT_4, 0x0f, 0x02); - snd_soc_component_update_bits(component, PCM512x_GPIO_CONTROL_1, 0x08, 0x08); + if (leds_off) + snd_soc_component_update_bits(component, PCM512x_GPIO_CONTROL_1, 0x08, 0x00); + else + snd_soc_component_update_bits(component, PCM512x_GPIO_CONTROL_1, 0x08, 0x08); if (digital_gain_0db_limit) { int ret; @@ -256,6 +260,8 @@ static int snd_rpi_hifiberry_dacplusadc_ struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_component *component = rtd->codec_dai->component; + if (leds_off) + return 0; snd_soc_component_update_bits(component, PCM512x_GPIO_CONTROL_1, 0x08, 0x08); hifiberry_dacplusadc_LED_cnt++; @@ -347,6 +353,8 @@ static int snd_rpi_hifiberry_dacplusadc_ pdev->dev.of_node, "hifiberry,24db_digital_gain"); slave = of_property_read_bool(pdev->dev.of_node, "hifiberry-dacplusadc,slave"); + leds_off = of_property_read_bool(pdev->dev.of_node, + "hifiberry-dacplusadc,leds_off"); ret = devm_snd_soc_register_card(&pdev->dev, &snd_rpi_hifiberry_dacplusadc);