From afea1f84cbda94c47ba4a8f84d16c4330e145a0a Mon Sep 17 00:00:00 2001 From: Phil Elwell Date: Wed, 12 Jun 2019 17:15:05 +0100 Subject: [PATCH] w1: w1-gpio: Make GPIO an output for strong pullup The logic to drive the data line high to implement a strong pullup assumed that the pin was already an output - setting a value does not change an input. See: https://github.com/raspberrypi/firmware/issues/1143 Signed-off-by: Phil Elwell --- drivers/w1/masters/w1-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/w1/masters/w1-gpio.c +++ b/drivers/w1/masters/w1-gpio.c @@ -33,7 +33,7 @@ static u8 w1_gpio_set_pullup(void *data, * This will OVERRIDE open drain emulation and force-pull * the line high for some time. */ - gpiod_set_raw_value(pdata->gpiod, 1); + gpiod_direction_output_raw(pdata->gpiod, 1); msleep(pdata->pullup_duration); /* * This will simply set the line as input since we are doing