From 5efb7855a9d33ac897d6e2a7117e4e3d35d433a5 Mon Sep 17 00:00:00 2001 From: Daniel Golle Date: Thu, 11 Mar 2021 10:28:53 +0000 Subject: [PATCH 01/21] Revert "clk: Add debugging for return values" This reverts commit 5c5992cb90cf9ca4d51e38d9a95a13c293904df5. --- drivers/clk/clk-uclass.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -84,7 +84,7 @@ static int clk_get_by_index_tail(int ret if (ret) { debug("%s: uclass_get_device_by_of_offset failed: err=%d\n", __func__, ret); - return log_msg_ret("get", ret); + return ret; } clk->dev = dev_clk; @@ -97,15 +97,14 @@ static int clk_get_by_index_tail(int ret ret = clk_of_xlate_default(clk, args); if (ret) { debug("of_xlate() failed: %d\n", ret); - return log_msg_ret("xlate", ret); + return ret; } return clk_request(dev_clk, clk); err: debug("%s: Node '%s', property '%s', failed to request CLK index %d: %d\n", __func__, ofnode_get_name(node), list_name, index, ret); - - return log_msg_ret("prop", ret); + return ret; } static int clk_get_by_indexed_prop(struct udevice *dev, const char *prop_name, @@ -124,7 +123,7 @@ static int clk_get_by_indexed_prop(struc if (ret) { debug("%s: fdtdec_parse_phandle_with_args failed: err=%d\n", __func__, ret); - return log_ret(ret); + return ret; } @@ -472,7 +471,6 @@ int clk_free(struct clk *clk) ulong clk_get_rate(struct clk *clk) { const struct clk_ops *ops; - int ret; debug("%s(clk=%p)\n", __func__, clk); if (!clk_valid(clk)) @@ -482,11 +480,7 @@ ulong clk_get_rate(struct clk *clk) if (!ops->get_rate) return -ENOSYS; - ret = ops->get_rate(clk); - if (ret) - return log_ret(ret); - - return 0; + return ops->get_rate(clk); } struct clk *clk_get_parent(struct clk *clk)