From 6c03b293bb2ba86f22ea6e20dd0266892932f585 Mon Sep 17 00:00:00 2001 From: Mathias Kresin Date: Mon, 26 Jun 2017 19:22:52 +0200 Subject: firmware-utils: fix dgn3500sum compiler warnings The sum variable need to be initialised, otherwise it will points to random stack memory and a bogus image checksum might be calculated. While at it, fix the segfault in case the product region code isn't specified and enable compiler warnings which had revealed all the code issues. Signed-off-by: Mathias Kresin --- tools/firmware-utils/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tools/firmware-utils/Makefile') diff --git a/tools/firmware-utils/Makefile b/tools/firmware-utils/Makefile index 69cba69a58..337d63582e 100644 --- a/tools/firmware-utils/Makefile +++ b/tools/firmware-utils/Makefile @@ -73,7 +73,7 @@ define Host/Compile $(call cc,mkdcs932, -Wall) $(call cc,mkheader_gemtek,-lz) $(call cc,mkrtn56uimg, -lz) - $(call cc,dgn3500sum) + $(call cc,dgn3500sum, -Wall) $(call cc,edimax_fw_header, -Wall) $(call cc,mkmerakifw sha1, -Wall) $(call cc,mkmerakifw-old, -Wall) -- cgit v1.2.3