From 0d23fd2ab29a66f5d03187db4fac3e396b4f3b62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Sun, 16 Dec 2018 12:26:34 +0100 Subject: treewide: dts: Remove default-state=off property from all gpio LED nodes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit >From the Documentation/devicetree/bindings/leds/common.txt: - default-state : The initial state of the LED. Valid values are "on", "off", and "keep". If the LED is already on or off and the default-state property is set the to same value, then no glitch should be produced where the LED momentarily turns off (or on). The "keep" setting will keep the LED at whatever its current state is, without producing a glitch. The default is off if this property is not present. So setting the default-state of the LEDs to `off` is redundant as `off` is default LED state anyway. We should remove it as almost every new PR/patch submission contains this property by default which seems to be just copy&paste from some DTS file already present in the tree. Signed-off-by: Petr Štetiar --- target/linux/ramips/dts/DCH-M225.dts | 1 - target/linux/ramips/dts/DIR-615-D.dts | 1 - target/linux/ramips/dts/DIR-615-H1.dts | 1 - target/linux/ramips/dts/EX3700.dts | 1 - target/linux/ramips/dts/MIWIFI-MINI.dts | 2 -- target/linux/ramips/dts/Newifi-D1.dts | 2 -- target/linux/ramips/dts/PBR-D1.dts | 1 - target/linux/ramips/dts/PSG1218A.dts | 2 -- target/linux/ramips/dts/PSG1218B.dts | 2 -- 9 files changed, 13 deletions(-) (limited to 'target/linux/ramips/dts') diff --git a/target/linux/ramips/dts/DCH-M225.dts b/target/linux/ramips/dts/DCH-M225.dts index a809546fab..e8f71ae160 100644 --- a/target/linux/ramips/dts/DCH-M225.dts +++ b/target/linux/ramips/dts/DCH-M225.dts @@ -45,7 +45,6 @@ status { label = "dch-m225:red:status"; gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; - default-state = "off"; }; }; diff --git a/target/linux/ramips/dts/DIR-615-D.dts b/target/linux/ramips/dts/DIR-615-D.dts index cb03520ff2..fbced8d139 100644 --- a/target/linux/ramips/dts/DIR-615-D.dts +++ b/target/linux/ramips/dts/DIR-615-D.dts @@ -76,7 +76,6 @@ status { label = "dir-615-d:amber:status"; gpios = <&gpio0 8 GPIO_ACTIVE_LOW>; - default-state = "off"; }; led_status_green: status2 { diff --git a/target/linux/ramips/dts/DIR-615-H1.dts b/target/linux/ramips/dts/DIR-615-H1.dts index 47ea183e6a..c81978b7de 100644 --- a/target/linux/ramips/dts/DIR-615-H1.dts +++ b/target/linux/ramips/dts/DIR-615-H1.dts @@ -22,7 +22,6 @@ status { label = "dir-615-h1:amber:status"; gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>; - default-state = "off"; }; led_status_green: status2 { diff --git a/target/linux/ramips/dts/EX3700.dts b/target/linux/ramips/dts/EX3700.dts index 939beed529..0232ab4412 100644 --- a/target/linux/ramips/dts/EX3700.dts +++ b/target/linux/ramips/dts/EX3700.dts @@ -34,7 +34,6 @@ power_a { label = "ex3700:amber:power"; gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; - default-state = "off"; }; router_g { diff --git a/target/linux/ramips/dts/MIWIFI-MINI.dts b/target/linux/ramips/dts/MIWIFI-MINI.dts index ed9fbdaa6e..e9f9c9663d 100644 --- a/target/linux/ramips/dts/MIWIFI-MINI.dts +++ b/target/linux/ramips/dts/MIWIFI-MINI.dts @@ -32,13 +32,11 @@ yellow { label = "miwifi-mini:yellow:status"; gpios = <&gpio1 2 GPIO_ACTIVE_LOW>; - default-state = "off"; }; red { label = "miwifi-mini:red:status"; gpios = <&gpio1 5 GPIO_ACTIVE_LOW>; - default-state = "off"; }; }; diff --git a/target/linux/ramips/dts/Newifi-D1.dts b/target/linux/ramips/dts/Newifi-D1.dts index 258af82364..37383fd3d8 100644 --- a/target/linux/ramips/dts/Newifi-D1.dts +++ b/target/linux/ramips/dts/Newifi-D1.dts @@ -31,13 +31,11 @@ status-red { label = "newifi-d1:red:status"; gpios = <&gpio0 14 GPIO_ACTIVE_LOW>; - default-state = "off"; }; status-green { label = "newifi-d1:green:status"; gpios = <&gpio0 13 GPIO_ACTIVE_LOW>; - default-state = "off"; }; led_blue: status-blue { diff --git a/target/linux/ramips/dts/PBR-D1.dts b/target/linux/ramips/dts/PBR-D1.dts index 8ea77d3f8a..5fe72bbc39 100644 --- a/target/linux/ramips/dts/PBR-D1.dts +++ b/target/linux/ramips/dts/PBR-D1.dts @@ -37,7 +37,6 @@ gpios = <&gpio0 0 GPIO_ACTIVE_LOW>; trigger-sources = <&ohci_port1>, <&ehci_port1>; linux,default-trigger = "usbport"; - default-state = "off"; }; led_power: power { diff --git a/target/linux/ramips/dts/PSG1218A.dts b/target/linux/ramips/dts/PSG1218A.dts index 57c032f38a..767070dbb5 100644 --- a/target/linux/ramips/dts/PSG1218A.dts +++ b/target/linux/ramips/dts/PSG1218A.dts @@ -24,13 +24,11 @@ yellow { label = "psg1218a:yellow:status"; gpios = <&gpio0 11 GPIO_ACTIVE_LOW>; - default-state = "off"; }; red { label = "psg1218a:red:status"; gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>; - default-state = "off"; }; }; }; diff --git a/target/linux/ramips/dts/PSG1218B.dts b/target/linux/ramips/dts/PSG1218B.dts index 8b6b8c0372..8f735a7d9a 100644 --- a/target/linux/ramips/dts/PSG1218B.dts +++ b/target/linux/ramips/dts/PSG1218B.dts @@ -24,13 +24,11 @@ yellow { label = "psg1218b:yellow:status"; gpios = <&gpio0 11 GPIO_ACTIVE_LOW>; - default-state = "off"; }; red { label = "psg1218b:red:status"; gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>; - default-state = "off"; }; }; }; -- cgit v1.2.3