From ad6b0770493e0fd332db9a7fe09f9214342c578b Mon Sep 17 00:00:00 2001 From: Adrian Schmutzler Date: Tue, 17 Aug 2021 14:07:57 +0200 Subject: ramips: mt7628: move mtd-eeprom out of root DTSI The mt76x8 subtarget is the only one in ramips that stores the mediatek,mtd-eeprom property directly in the "root" mt7628an.dtsi. This is not optimal for a few different reasons: * If you don't really know it or are used to other (sub)targets, the property will be set somewhat magically. * The property is set based on &factory partition before (if at all) this partition is defined. * There are several devices that have different offset or even different partitions to read from, which will then be overwritten in the DTS files. Thus, definitions are scattered between root DTSI and individual files. Based on these circumstances, the "root" definition is removed and the property is added to the device-based DTS(I) files where needed and applicable. This should be easier to grasp for unexperienced developers and will move the property closer to the partition definitions. Signed-off-by: Adrian Schmutzler --- target/linux/ramips/dts/mt7628an_tplink_8m.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'target/linux/ramips/dts/mt7628an_tplink_8m.dtsi') diff --git a/target/linux/ramips/dts/mt7628an_tplink_8m.dtsi b/target/linux/ramips/dts/mt7628an_tplink_8m.dtsi index 8372f057cd..ecb6ce1e4e 100644 --- a/target/linux/ramips/dts/mt7628an_tplink_8m.dtsi +++ b/target/linux/ramips/dts/mt7628an_tplink_8m.dtsi @@ -55,9 +55,11 @@ &wmac { status = "okay"; + + mediatek,mtd-eeprom = <&factory 0x20000>; + nvmem-cells = <&macaddr_factory_f100>; nvmem-cell-names = "mac-address"; - mediatek,mtd-eeprom = <&factory 0x20000>; }; ðernet { -- cgit v1.2.3