From 8b0c053671e5fb7f36c123a281c51a8071bf96e3 Mon Sep 17 00:00:00 2001
From: Christian Lamparter <chunkeey@gmail.com>
Date: Thu, 13 Aug 2020 18:26:19 +0200
Subject: apm821xx: implement new LED label naming scheme

This patch updates all current APM82181 devices over to that
"new LED naming scheme". This includes many updates to the
device-tree:
	- dropped the deprecated, but beloved "label" property.
	- rename all DT leds node names to led-#.
	- add function and color properties.
	- utilized panic-indicator property.
	- dropped led- aliases (see below).

migration scripts for all devices are included.

For more information. See:
<https://www.kernel.org/doc/html/latest/leds/leds-class.html>

For the future: It looks like the color+function properties
won over the dt-alias / label. This will need to be wired up
into openwrt eventually. For APM821xx the situation is that
all devices have a dedicated power and fault indicator.

Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
 target/linux/apm821xx/dts/netgear-wndr4700.dts | 55 +++++++++++++++-----------
 1 file changed, 31 insertions(+), 24 deletions(-)

(limited to 'target/linux/apm821xx/dts/netgear-wndr4700.dts')

diff --git a/target/linux/apm821xx/dts/netgear-wndr4700.dts b/target/linux/apm821xx/dts/netgear-wndr4700.dts
index ad23e8b441..286eba203b 100644
--- a/target/linux/apm821xx/dts/netgear-wndr4700.dts
+++ b/target/linux/apm821xx/dts/netgear-wndr4700.dts
@@ -7,8 +7,9 @@
 
 /dts-v1/;
 
-#include "apm82181.dtsi"
 #include <dt-bindings/thermal/thermal.h>
+#include <dt-bindings/leds/common.h>
+#include "apm82181.dtsi"
 
 / {
 	model = "Netgear WNDR4700/WNDR4720 Series";
@@ -16,10 +17,6 @@
 
 	aliases {
 		serial0 = &UART0;
-		led-boot = &status;
-		led-failsafe = &failsafe;
-		led-running = &status;
-		led-upgrade = &status;
 	};
 
 	chosen {
@@ -367,53 +364,63 @@
 
 	leds {
 		compatible = "gpio-leds";
-		status: power-green {
-			label = "wndr4700:green:power";
+
+		led-0 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_POWER;
 			gpios = <&GPIO0 8 GPIO_ACTIVE_HIGH>;
 		};
 
-		failsafe: power-orange {
-			label = "wndr4700:orange:power";
+		led-1 {
+			color = <LED_COLOR_ID_AMBER>;
+			function = LED_FUNCTION_FAULT;
 			gpios = <&GPIO0 9 GPIO_ACTIVE_LOW>;
-			linux,default-trigger = "panic";
+			panic-indicator;
 		};
 
-		usb-blue {
-			label = "wndr4700:blue:usb";
+		led-2 {
+			color = <LED_COLOR_ID_BLUE>;
+			function = LED_FUNCTION_USB;
 			gpios = <&GPIO0 10 GPIO_ACTIVE_HIGH>;
 			trigger-sources = <&usb2_port 1>, <&usb2_port 2>,
 					  <&usb3_port 1>, <&usb3_port 2>;
 			linux,default-trigger = "usbport";
 		};
 
-		logo-white {
-			label = "wndr4700:white:logo";
+		led-3 {
+			color = <LED_COLOR_ID_WHITE>;
+			function = LED_FUNCTION_INDICATOR;
 			gpios = <&GPIO0 11 GPIO_ACTIVE_HIGH>;
 		};
 
-		wan-yellow {
-			label = "wndr4700:yellow:wan";
+		led-4 {
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_WAN;
 			gpios = <&GPIO0 3 GPIO_ACTIVE_HIGH>;
 		};
 
-		wan-green {
-			label = "wndr4700:green:wan";
+		led-5 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_WAN;
 			gpios = <&GPIO0 12 GPIO_ACTIVE_HIGH>;
 		};
 
-		hd-green {
-			label = "wndr4700:green:hd";
+		led-6 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_DISK;
 			gpios = <&GPIO0 14 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "disk-activity";
 		};
 
-		hd-red {
-			label = "wndr4700:red:hd";
+		led-7 {
+			color = <LED_COLOR_ID_RED>;
+			function = LED_FUNCTION_DISK_ERR;
 			gpios = <&GPIO0 17 GPIO_ACTIVE_HIGH>;
 		};
 
-		wlan-blue {
-			label = "wndr4700:blue:wlan";
+		led-8 {
+			color = <LED_COLOR_ID_BLUE>;
+			function = LED_FUNCTION_WLAN;
 			gpios = <&GPIO0 18 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "phy0tpt";
 		};
-- 
cgit v1.2.3