From e723b7928ac7f10adddcb6986930a4c0f8a7ac79 Mon Sep 17 00:00:00 2001 From: John Crispin Date: Mon, 25 Aug 2014 06:35:50 +0000 Subject: package/*: remove useless explicit set of function returncode somebody started to set a function returncode in the validation stuff and everybody copies it, e.g. myfunction() { fire_command return $? } a function automatically returns with the last returncode, so we can safely remove the command 'return $?'. reference: http://tldp.org/LDP/abs/html/exit-status.html "The last command executed in the function or script determines the exit status." Signed-off-by: Bastian Bittorf git-svn-id: svn://svn.openwrt.org/openwrt/trunk@42278 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- package/utils/busybox/files/sysntpd | 1 - 1 file changed, 1 deletion(-) (limited to 'package/utils/busybox') diff --git a/package/utils/busybox/files/sysntpd b/package/utils/busybox/files/sysntpd index 1878c3f594..417addfb1c 100755 --- a/package/utils/busybox/files/sysntpd +++ b/package/utils/busybox/files/sysntpd @@ -9,7 +9,6 @@ PROG=/usr/sbin/ntpd validate_ntp_section() { uci_validate_section system timeserver "${1}" \ 'server:list(host)' 'enabled:bool:1' 'enable_server:bool:0' - return $? } start_service() { -- cgit v1.2.3