From e723b7928ac7f10adddcb6986930a4c0f8a7ac79 Mon Sep 17 00:00:00 2001 From: John Crispin Date: Mon, 25 Aug 2014 06:35:50 +0000 Subject: package/*: remove useless explicit set of function returncode somebody started to set a function returncode in the validation stuff and everybody copies it, e.g. myfunction() { fire_command return $? } a function automatically returns with the last returncode, so we can safely remove the command 'return $?'. reference: http://tldp.org/LDP/abs/html/exit-status.html "The last command executed in the function or script determines the exit status." Signed-off-by: Bastian Bittorf git-svn-id: svn://svn.openwrt.org/openwrt/trunk@42278 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- package/system/ubox/files/log.init | 2 -- 1 file changed, 2 deletions(-) (limited to 'package/system/ubox') diff --git a/package/system/ubox/files/log.init b/package/system/ubox/files/log.init index be382972e3..3e06fa5b49 100644 --- a/package/system/ubox/files/log.init +++ b/package/system/ubox/files/log.init @@ -19,7 +19,6 @@ validate_log_section() 'log_port:port:514' \ 'log_proto:or("tcp", "udp"):udp' \ 'log_prefix:string' - return $? } validate_log_daemon() @@ -27,7 +26,6 @@ validate_log_daemon() uci_validate_section system system "${1}" \ 'log_size:uinteger:0' \ 'log_buffer_size:uinteger:0' - return $? } start_service_daemon() -- cgit v1.2.3