From 2ae05c57f8d4cb557a5ea733c2795b8462f00062 Mon Sep 17 00:00:00 2001 From: John Crispin Date: Mon, 25 Aug 2014 06:35:50 +0000 Subject: package/*: remove useless explicit set of function returncode somebody started to set a function returncode in the validation stuff and everybody copies it, e.g. myfunction() { fire_command return $? } a function automatically returns with the last returncode, so we can safely remove the command 'return $?'. reference: http://tldp.org/LDP/abs/html/exit-status.html "The last command executed in the function or script determines the exit status." Signed-off-by: Bastian Bittorf SVN-Revision: 42278 --- package/network/config/firewall/files/firewall.init | 4 ---- 1 file changed, 4 deletions(-) (limited to 'package/network/config/firewall/files/firewall.init') diff --git a/package/network/config/firewall/files/firewall.init b/package/network/config/firewall/files/firewall.init index 662dd8010b..ee3ed1a283 100755 --- a/package/network/config/firewall/files/firewall.init +++ b/package/network/config/firewall/files/firewall.init @@ -15,8 +15,6 @@ validate_firewall_redirect() 'dest_ip:cidr' \ 'dest_port:or(port, portrange)' \ 'target:or("SNAT", "DNAT")' - - return $? } validate_firewall_rule() @@ -28,8 +26,6 @@ validate_firewall_rule() 'src_port:or(port, portrange)' \ 'dest_port:or(port, portrange)' \ 'target:string' - - return $? } service_triggers() { -- cgit v1.2.3