aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* ramips: mt7621-dts: fix phy-mode of external phy on GB-PC2Arınç ÜNAL2023-02-031-1/+1
| | | | | | | | | The phy-mode property must be defined on the MAC instead of the PHY. Define phy-mode under gmac1 which the external phy is connected to. Tested-by: Petr Louda <petr.louda@outlook.cz> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> (cherry picked from commit 5155200f97adaeaaac7b752b5a6a5e41cba3db6a)
* octeontx: add sqaushfs and ramdisk to featuresTim Harvey2023-02-031-1/+1
| | | | | | | | Add squashfs and ramdisk to features as these are commonly used images for the octeontx. Signed-off-by: Tim Harvey <tharvey@gateworks.com> (cherry picked from commit af5635e6ca12d3be275560a58ac6e2793e218fcd)
* ath79: add LTE packages for GL-XE300Tom Herbers2023-02-031-1/+2
| | | | | | | | | | | | | | | | | | Add LTE packages required for operating the LTE modems shipped with the GL-XE300. Example configuration for an unauthenticated dual-stack APN: network.wwan0=interface network.wwan0.proto='qmi' network.wwan0.device='/dev/cdc-wdm0' network.wwan0.apn='internet' network.wwan0.auth='none' network.wwan0.delay='10' network.wwan0.pdptype='IPV4V6' Signed-off-by: Tom Herbers <mail@tomherbers.de> (cherry picked from commit 67f283be4430ebfb46be6c00fcc7c12a6adabce3)
* ath79: add label-mac-device for GL-XE300Tom Herbers2023-02-031-0/+4
| | | | | | | | This adds an label-mac-device alias which refrences the mac which is printed on the Label of the device. Signed-off-by: Tom Herbers <mail@tomherbers.de> (cherry picked from commit f83f5f8452edd3115aacf333b0038da89639a218)
* ath79: add LTE led for GL.iNet GL-XE300Leo Soares2023-02-031-0/+1
| | | | | | | | | This commit adds the LTE led for GL.iNet GL-XE300 to the default leds config. Signed-off-by: Leo Soares <leo@hyper.ag> (cherry picked from commit 35a0f2b00c44a43ad087327f0cbdb1c9c5e60c49) Signed-off-by: Tom Herbers <mail@tomherbers.de>
* kernel: backport some mv88e6xxx devlink patchesEtienne Champetier2023-01-313-0/+374
| | | | | | This should help debug mv88e6xxx issues Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
* kernel: bump 5.10 to 5.10.165John Audia2023-01-289-12/+12
| | | | | | | | | | | All patches automatically rebased. Build system: x86_64 Build-tested: ramips/tplink_archer-a6-v3 Run-tested: ramips/tplink_archer-a6-v3 Signed-off-by: John Audia <therealgraysky@proton.me> (cherry picked from commit 257e9fc57cf2c0391f8d99c25e82d75b73695c8a)
* kernel: bump 5.10 to 5.10.164John Audia2023-01-286-9/+9
| | | | | | | | | | | All patches automatically rebased Build system: x86_64 Build-tested: ramips/tplink_archer-a6-v3 Run-tested: ramips/tplink_archer-a6-v3 Signed-off-by: John Audia <therealgraysky@proton.me> (cherry picked from commit 9c3954bc46fce58a0f2dbe8bf6d3f507cfcd1dfb)
* kernel: bump 5.10 to 5.10.163John Audia2023-01-2878-217/+151
| | | | | | | | | | | | | | | | | Removed upstreamed: generic/101-Use-stddefs.h-instead-of-compiler.h.patch[1] bcm27xx/patches-5.10/950-0194-drm-fourcc-Add-packed-10bit-YUV-4-2-0-format.patch All patches automatically rebased. 1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.163&id=ddd2bb08bd99b7ee4442fbbe0f9b80236fdd71d2 Build system: x86_64 Build-tested: ramips/tplink_archer-a6-v3 Run-tested: ramips/tplink_archer-a6-v3 Signed-off-by: John Audia <therealgraysky@proton.me> (cherry picked from commit 2835df54ab84a8709057df156932497b19cda449)
* kernel: bump 5.10 to 5.10.162John Audia2023-01-282-3/+3
| | | | | | | | | | | All patches automatically rebased. Build system: x86_64 Build-tested: ramips/tplink_archer-a6-v3 Run-tested: ramips/tplink_archer-a6-v3 Signed-off-by: John Audia <therealgraysky@proton.me> (cherry picked from commit 2621ddb0bef7f5f8eedc49437dfa23b66e810af6)
* mac80211: use 802.11ax iw modesDavid Bauer2023-01-281-3/+3
| | | | | | | | | | | This adds missing HE modes to mac80211_prepare_ht_modes. Previously mesh without wpa_supplicant would be initialized with 802.11g /NO-HT only, as this method did not parse channel bandwidth for HE operation. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit a63430eac33ceb1dbf96d3667e2a0f2e04ba391f)
* kernel: mtk-bmt: fix usage of _oob_readChuanhong Guo2023-01-251-2/+8
| | | | | | | | | _oob_read returns number of bitflips on success while bbt_nand_read should return 0. Fixes: 2d49e49b18 ("mediatek: bmt: use generic mtd api") Signed-off-by: Chuanhong Guo <gch981213@gmail.com> (cherry picked from commit f183ce35b8ea2fd991ac489fb223b09a1ecb4db0)
* tools/mkimage: build uboot with NO_SDL=1Christian Marangi2023-01-221-0/+1
| | | | | | | | | From uboot Documentation for uboot-2022.01 for tools-only we can build with NO_SDL=1 to skip installing the sdl2 package. Follow this to fix compilation error on macos Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
* lantiq: xrx200: Fix wifi LED on o2 box 6431Florian Maurer2023-01-202-1/+1
| | | | | | | | Wifi LED did not work using phy0radio, which somehow slipped through in the previous testing Signed-off-by: Florian Maurer <f.maurer@outlook.de> (cherry picked from commit 2e3d1edf59109d6329a00d90b1e953261d602af5)
* mbedtls: move source modification to patchDavid Bauer2023-01-182-3/+15
| | | | | | | | Patch the mbedtls source instead of modifying the compile-targets in the prepare buildstep within OpenWrt. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit 00f1463df7e690862403208082f71fb4741baf02)
* Revert "toolchaini/gcc: fix libstdc++ dual abi model"Petr Štetiar2023-01-181-1/+1
| | | | | | | | | This reverts commit c0b4303d2e2f4a9e1d4684fd584e6b6548666f0f as it was reported, that it breaks all packages depending on libstdcpp due to changed ABI. References: https://github.com/openwrt/packages/issues/20340 Signed-off-by: Petr Štetiar <ynezz@true.cz>
* dosfstools: switch to AC_CHECK_LIBDavid Bauer2023-01-161-0/+28
| | | | | | | | | This fixes spurious build-errors on OpenWrt, where the AM_ICONV macro is undefined while invoking autoconfig. Later in the build, the ICONV LDOPTIONS are set to @LIBICONV@, failing the build. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit 9300a20dcce2217b121bd2020cc1a4ea41fa4475)
* tools/dosfstools: fix PKG_SOURCEStijn Tintel2023-01-161-2/+2
| | | | | | | | | Both mirrors provided in the Makefile only serve gzipped tarballs. Fixes: #10871 Fixes: 9edfe7dd13d9 ("source: Switch to xz for packages and tools where possible") Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be> (cherry picked from commit bd911b45389b3da299948b457a1fc645febd2248)
* toolchaini/gcc: fix libstdc++ dual abi modelIvan Maslov2023-01-161-1/+1
| | | | | | | | | | | libstdcxx-dual-abi needs to be enabled to actually support C++11 ABI. Enable the config flag to also permit support of .NET 6 development on OpenWrt. Signed-off-by: Ivan Maslov <avenger_msoft@mail.ru> [ reword commit description and title ] Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> (cherry picked from commit 3c06a344e9c7c03c49c9153342e68a5390651323)
* scripts/dl_github_archieve.py: fix generating unreproducible tarChristian Marangi2023-01-121-1/+1
| | | | | | | | | | | | | | | | Allign dl_github_archieve.py to 8252511dc0b5a71e9e64b96f233a27ad73e28b7f change. On supported system the sigid bit is applied to files and tar archieve that on tar creation. This cause unreproducible tar for these system and these bit should be dropped to produce reproducible tar. Add the missing option following the command options used in other scripts. Fixes: 75ab064d2b38 ("build: download code from github using archive API") Suggested-by: Eneas U de Queiroz <cotequeiroz@gmail.com> Tested-by: Robert Marko <robimarko@gmail.com> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> (cherry picked from commit 5f1758ef14575df4e86896526b1c2035c231899e)
* ksmbd: Fix ZDI-CAN-18259Hauke Mehrtens2023-01-113-1/+100
| | | | | | | | | | | | This fixes a security problem in ksmbd. It currently has the ZDI-CAN-18259 ID assigned, but no CVE yet. Backported from: https://github.com/cifsd-team/ksmbd/commit/8824b7af409f51f1316e92e9887c2fd48c0b26d6 https://github.com/cifsd-team/ksmbd/commit/cc4f3b5a6ab4693aba94a45cc073188df4d67175 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit 76c67fcc66116381c69439f20159b636573080ba)
* ksmbd: update to 3.4.6Nick Hainke2023-01-072-55/+2
| | | | | | | | | | | | | | | | | | | Release Announcement: https://github.com/cifsd-team/ksmbd/releases/tag/3.4.6 Remove upstreamed: - 10-fix-build-on-kernel-5.15.52-or-higher.patch This fixes the following security bugs: * CVE-2022-47938, ZDI-22-1689 * CVE-2022-47939, ZDI-22-1690 (patch was already backported before) * CVE-2022-47940, ZDI-22-1691 * CVE-2022-47941, ZDI-22-1687 * CVE-2022-47942, ZDI-22-1688 * CVE-2022-47943, ZDI-CAN-17817 Signed-off-by: Nick Hainke <vincent@systemli.org> (cherry picked from commit 78cbcc77cc33638b185f85c0e40daee1906a2c3c)
* lantiq-xrx200: fix wan LED on o2 box 6431Florian Maurer2023-01-061-1/+4
| | | | | | | | | | | | | The WIFI LED already worked for me with the latest openwrt 22.03 version. Wifi LED did not with an older 22.x version (in gluon - there phy0radio did nothing but phy0tpt did show activity the WAN interface has the name "wan" and not "pppoe-wan" on this device fixes #7757 (and FS#2987) Signed-off-by: Florian Maurer <f.maurer@outlook.de> (cherry picked from commit 0820d620123a03b6db6642acb6e950d22ffb030f) Signed-off-by: Jan-Niklas Burfeind <git@aiyionpri.me>
* CI: build: fix external toolchain use with release tag testsChristian Marangi2023-01-041-1/+1
| | | | | | | | | | | | | | | When a new tag for a release is created, the just checkout repo from github actions will already have such tag locally created. This will result in git fetch --tags failing with error rejecting the remote tag with (would clobber existing tag). Add -f option to overwrite any local tags and always fetch them from remote. Fixes: e24a1e6f6d7f ("CI: build: add support for external toolchains from stable branch") Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> (cherry picked from commit f655923b362e9f2d70672eee9c1fa82550a145a6)
* OpenWrt v22.03.3: revert to branch defaultsHauke Mehrtens2023-01-035-11/+9
| | | | Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
* OpenWrt v22.03.3: adjust config defaultsv22.03.3Hauke Mehrtens2023-01-035-9/+11
| | | | Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
* mac80211: Do not build brcmsmac on bcm47xx_legacyHauke Mehrtens2023-01-031-1/+1
| | | | | | | | | | brcmsmac needs bcma. bcma is build into the kernel for the other bcm47xx subtargets, but not for the legacy target because it only uses ssb. We could build bcma as a module for bcm47xx_legacy, but none of these old devices uses a wifi card supported by brcsmac. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit cb7d662dac897dd7df6ba6ba60417db822bd68f2)
* uml: fix 5.10 buildChristian Lamparter2023-01-031-0/+32
| | | | | | | | | | | | | | the 5.10 uml build currently breaks with: /usr/bin/ld: arch/um/os-Linux/signal.o: in function `sigusr1_handler': arch/um/os-Linux/signal.c:141: undefined reference to `uml_pm_wake' But there's an upstream fix for this. Backport the fix for now but also let upstream know so it finds its way through the -stable releases. Signed-off-by: Christian Lamparter <chunkeey@gmail.com> (cherry picked from commit 8bea5edf89e57c32b98620540a457441f5f8ddeb)
* kernel: Add missing kernel configuration optionsHauke Mehrtens2023-01-035-4/+3
| | | | | | | This fixes compile of the bmips target. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit f620eb70f1a10385c33a9833e1c97d8c7fef0093)
* gdb: Do not link against xxhashHauke Mehrtens2023-01-021-0/+1
| | | | | | | | | | | libxxhash is now available in the OpenWrt package feed and gdb will link against it if gdb finds this library. Explicitly deactivate the usage of xxhash. This should fix the build of gdb in build bots. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit a442974cfa89c7182c37b3b422b2d49319e2b339)
* odhcpd: fix null pointer dereference for INFORM messagesHans Dedecker2023-01-021-3/+3
| | | | | | 4a673e1 fix null pointer dereference for INFORM messages Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
* ipq40xx: sysupgrade: allow flashing Linksys factory firmwareTony Ambardar2023-01-011-0/+18
| | | | | | | | | | | | | | | | | | Allow forced flashing of a factory firmware image, after checking for the correct FIT magic header and Linksys board-specific footer. Details of the footer are already described in scripts/linksys-image.sh. This is convenient as it avoids using a TFTP server or OEM GUI, and allows restoring OEM firmware or installing a "breaking" OpenWrt update (e.g DSA migration and kernel repartition) directly from the command line. Devices supported at this time include EA6350v3, EA8300, MR8300 and WHW01. Reviewed-by: Robert Marko <robimarko@gmail.com> Tested-by: Wyatt Martin <wawowl@gmail.com> # WHW01 Tested-by: Tony Ambardar <itugrok@yahoo.com> # EA6350v3 Signed-off-by: Tony Ambardar <itugrok@yahoo.com> (cherry picked from commit 6fc334cbdc2b1716786768c545b761b338962b43)
* base-files: stage2: add 'tail' to sysupgrade environmentTony Ambardar2023-01-011-1/+1
| | | | | | | | This is used to access footer data in firmare files, and is simpler and less error-prone than using 'dd' with calculated offsets. Signed-off-by: Tony Ambardar <itugrok@yahoo.com> (cherry picked from commit 9cbc825b30a60c4c4b466301b87e15e59b107f24)
* treewide: Trigger reinstall of all wolfssl dependenciesHauke Mehrtens2023-01-014-4/+4
| | | | | | | | | The ABI of the wolfssl library changed a bit between version 5.5.3 and 5.5.4. This release update will trigger a rebuild of all packages which are using wolfssl to make sure they are adapted to the new ABI. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit ee47a28cec01c7943238bae45f65a98e4fc9abbe)
* wolfssl: update to 5.5.4-stableNick Hainke2023-01-013-36/+3
| | | | | | | | | | | | | | Remove upstreamed: - 001-Fix-enable-devcrypto-build-error.patch Refresh patch: - 100-disable-hardening-check.patch Release notes: https://github.com/wolfSSL/wolfssl/releases/tag/v5.5.4-stable Signed-off-by: Nick Hainke <vincent@systemli.org> (cherry picked from commit 04634b2d8253972a3e7b663231474eb564e69077)
* mbedtls: update to version 2.28.2Hauke Mehrtens2022-12-312-6/+6
| | | | | | | | | | | | | | | | | | | | Changelog: https://github.com/Mbed-TLS/mbedtls/releases/tag/v2.28.2 This release of Mbed TLS provides bug fixes and minor enhancements. This release includes fixes for security issues. Fixes the following CVEs: * CVE-2022-46393: Fix potential heap buffer overread and overwrite in DTLS if MBEDTLS_SSL_DTLS_CONNECTION_ID is enabled and MBEDTLS_SSL_CID_IN_LEN_MAX > 2 * MBEDTLS_SSL_CID_OUT_LEN_MAX. * CVE-2022-46392: An adversary with access to precise enough information about memory accesses (typically, an untrusted operating system attacking a secure enclave) could recover an RSA private key after observing the victim performing a single private-key operation if the window size used for the exponentiation was 3 or smaller. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit af3c9b74e177019b18055c263099a42c1c6c3453)
* toolchain: gcc: import patch fixing asm machine directive for powerpcNick Hainke2022-12-281-0/+54
| | | | | | | | | | | | Applications with libmbedtls, e.g. curl, fail on mpc85xx with: curl[7227]: illegal instruction (4) at b7c94288 nip b7c94288 lr b7c6b528 code 1 in libmbedcrypto.so.2.28.1[b7c3e000+7e000] curl[7227]: code: 3d7e0000 809e8004 91490000 816b814c 7d6903a6 4e800421 80010024 83c10018 curl[7227]: code: 38210020 7c0803a6 4e800020 9421fff0 <7d4d42e6> 7c6c42e6 7d2d42e6 7c0a4840 This is due to a bug in gcc-11.2.0. It is fixed with gcc-11.3.0. Import the patch that is fixing the issue. Signed-off-by: Nick Hainke <vincent@systemli.org>
* kernel: remove hack patch, move kirkwood specific kmods to target modules.mkFelix Fietkau2022-12-274-55/+30
| | | | | | | | Tweaking the KCONFIG line of kmod-ata-marvell-sata makes the hack patch unnecessary Signed-off-by: Felix Fietkau <nbd@nbd.name> (cherry picked from commit 2e375e9b3148cfdb9b19494a25eebc2fa7b256a3)
* kernel: bump 5.10 to 5.10.161John Audia2022-12-265-6/+6
| | | | | | | | | | | All patches automatically rebased. Build system: x86_64 Build-tested: ramips/tplink_archer-a6-v3 Run-tested: ramips/tplink_archer-a6-v3 Signed-off-by: John Audia <therealgraysky@proton.me> (cherry picked from commit 59254010077c9086afee8a8b4c490943d6749065)
* uhttpd: update to latest Git HEADHauke Mehrtens2022-12-261-3/+3
| | | | | | | 2397755 client: fix incorrectly emitting HTTP 413 for certain content lengths Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit 73dca49f355fe10d1d5e629b0df584b03a1849b3)
* kernel: backport ksmbd security fix ZDI-22-1690Daniel Graña2022-12-231-0/+53
| | | | | | | Fix zero day vulnerability reported as ZDI-22-1690, no CVE assigned yet. Picked from https://github.com/cifsd-team/ksmbd/commit/1f9d85a340 Signed-off-by: Daniel Graña <dangra@gmail.com>
* Revert "image-commands.mk: Be consistent in command invocation"Hauke Mehrtens2022-12-221-1/+1
| | | | | | | | | | This reverts commit fcff234fd89e8b24aa3ad2f352ddbb5304c38dc1. $(STAGING_DIR_HOST)/bin/gzip is not available in openwrt-22.03. The change broke the build because the build process could not find this file. For example ath79/generic netgear_wndap360 was affected. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
* sunxi: remove frequency for NanoPi R1Jan-Niklas Burfeind2022-12-221-2/+1
| | | | | | | | The frequency appears as unlisted initial frequency. Removed it as Hauke suggested. Signed-off-by: Jan-Niklas Burfeind <git@aiyionpri.me> (cherry picked from commit 5b82eeb320d9f8e543232bb5dd004e644b35983e)
* arm-trusted-firmware-sunxi: drop CPE IDStijn Tintel2022-12-221-1/+0
| | | | | | | The CPE ID is already set in trusted-firmware-a.mk. Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be> (cherry picked from commit 9ed1830bdc1e58efb3e5b17c0e484e1a2655b550)
* trusted-firmware-a.mk: use correct CPE IDStijn Tintel2022-12-221-1/+1
| | | | | | | | | | | | | | | | | There are 2 different CPE IDs on the NVD website: cpe:/a:arm:trusted_firmware-a cpe:/o:arm:arm_trusted_firmware The ID as currently used in trusted-firmware-a.mk does not exist. The CPE ID using the arm_trusted_firmware product name only lists a few records for versions 2.2 and 2.3 on the NVD site. The CPE ID using the trusted_firmware-a product name lists many more records, and actually has a CVE linked to it. Therefore, use the CPE ID using the trusted_firmware-a product name. Fixes: 104d60fe94ce ("trusted-firmware-a.mk: add PKG_CPE_ID") Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be> (cherry picked from commit c8c6508c22c59a09b7acce63bed28947788a46d4)
* kernel: bump 5.10 to 5.10.160John Audia2022-12-221-2/+2
| | | | | | | | | | | No patches affected by this update. Build system: x86_64 Build-tested: ramips/tplink_archer-a6-v3 Run-tested: ramips/tplink_archer-a6-v3 Signed-off-by: John Audia <therealgraysky@proton.me> (cherry picked from commit 1e375c8fbd6a3259ffbbbde13eb0c106bedbcd1c)
* ath79: image: don't depend on other COMPILE targetsAlexander Couzens2022-12-221-1/+1
| | | | | | | | | | A device COMPILE target should not depend on another COMPILE. Otherwise race condition may happen. The loader is very small. Compiling it twice shouldn't have a huge impact. Signed-off-by: Alexander Couzens <lynxis@fe80.eu> (cherry picked from commit 17c6fb1054e3dde8fa573195acaac42a5edf0942)
* image: fix device profile specific COMPILE targetsMichael Pratt2022-12-221-0/+1
| | | | | | | | | | | | | | | | Commit a01d23e75 ("image: always rebuild kernel loaders") is a step in the right direction, but exposed some issues and regressions in the makefile. Some of the files made by device specific COMPILE targets start with an "append" command (i.e. >> instead of > redirection) and if the file already exists, the target file is the input to itself before the first recipe-specified input. Fixes: a01d23e75 ("image: always rebuild kernel loaders") Fixes: a7fb589e8 ("image: always rebuild kernel loaders") Signed-off-by: Michael Pratt <mcpratt@pm.me> (cherry picked from commit 1bff0752bd5e7feb0f311224a09b3bf217a9aeb3)
* rules: fix broken commitcount on alpine systemChristian Marangi2022-12-221-1/+1
| | | | | | | | | | To generate commitcount we use grep --max-count. This is not present on alpine grep and cause wrong generation. Use -m as it's just the short version of --max-count and more portable. Fixes: #11200 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> (cherry picked from commit eb7ffeafbfa78235b05abb4ae479376150d7a814)
* image-commands.mk: Be consistent in command invocationOlliver Schinagl2022-12-221-1/+1
| | | | | | | | Most/all other tools use the staging dir prefix, gzip should as well. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> Acked-by: Christian Marangi <ansuelsmth@gmail.com> (cherry picked from commit 47df168dd279d52127f6bbc623e79bdeeb6c8fd4)