aboutsummaryrefslogtreecommitdiffstats
path: root/target/linux/brcm2708/patches-4.19/950-0480-staging-bcm2835-audio-double-free-in-init-error-path.patch
diff options
context:
space:
mode:
Diffstat (limited to 'target/linux/brcm2708/patches-4.19/950-0480-staging-bcm2835-audio-double-free-in-init-error-path.patch')
-rw-r--r--target/linux/brcm2708/patches-4.19/950-0480-staging-bcm2835-audio-double-free-in-init-error-path.patch30
1 files changed, 30 insertions, 0 deletions
diff --git a/target/linux/brcm2708/patches-4.19/950-0480-staging-bcm2835-audio-double-free-in-init-error-path.patch b/target/linux/brcm2708/patches-4.19/950-0480-staging-bcm2835-audio-double-free-in-init-error-path.patch
new file mode 100644
index 0000000000..f5a83bd1b9
--- /dev/null
+++ b/target/linux/brcm2708/patches-4.19/950-0480-staging-bcm2835-audio-double-free-in-init-error-path.patch
@@ -0,0 +1,30 @@
+From 9886534de7551e0a59e90677bd1bab0539102772 Mon Sep 17 00:00:00 2001
+From: Dan Carpenter <dan.carpenter@oracle.com>
+Date: Mon, 17 Dec 2018 10:08:54 +0300
+Subject: [PATCH 480/703] staging: bcm2835-audio: double free in init error
+ path
+
+commit 136ff5e49271c4c8fceeca5491c48e66b961564b upstream.
+
+We free instance here and in the caller. It should be only the caller
+which handles it.
+
+Fixes: d7ca3a71545b ("staging: bcm2835-audio: Operate non-atomic PCM ops")
+Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
+Reviewed-by: Takashi Iwai <tiwai@suse.de>
+Cc: stable <stable@vger.kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 1 -
+ 1 file changed, 1 deletion(-)
+
+--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
++++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
+@@ -145,7 +145,6 @@ vc_vchi_audio_init(VCHI_INSTANCE_T vchi_
+ dev_err(instance->dev,
+ "failed to open VCHI service connection (status=%d)\n",
+ status);
+- kfree(instance);
+ return -EPERM;
+ }
+