diff options
Diffstat (limited to 'target/linux/brcm2708/patches-4.19/950-0469-staging-bcm2835-audio-update-TODO.patch')
-rw-r--r-- | target/linux/brcm2708/patches-4.19/950-0469-staging-bcm2835-audio-update-TODO.patch | 56 |
1 files changed, 0 insertions, 56 deletions
diff --git a/target/linux/brcm2708/patches-4.19/950-0469-staging-bcm2835-audio-update-TODO.patch b/target/linux/brcm2708/patches-4.19/950-0469-staging-bcm2835-audio-update-TODO.patch deleted file mode 100644 index da2a032deb..0000000000 --- a/target/linux/brcm2708/patches-4.19/950-0469-staging-bcm2835-audio-update-TODO.patch +++ /dev/null @@ -1,56 +0,0 @@ -From 56b704581afbd8d9ccd73cfa7935b6178749a3e9 Mon Sep 17 00:00:00 2001 -From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> -Date: Wed, 17 Oct 2018 21:01:56 +0200 -Subject: [PATCH 469/806] staging: bcm2835-audio: update TODO - -commit 01ec7398c56e8f1b903ecb3c5c75400e263eef43 upstream. - -The following tasks were completed or not the right solution: - -1/2- Not the proper solution, we should register a platform device in -vchiq the same way it's done with bcm2835-camera as commented here: -https://lkml.org/lkml/2018/10/16/1131 - -2/3- Fixed by Takashi Iwai here: https://lkml.org/lkml/2018/9/4/587 - -Also, adds a new task as per mailing list conversation. - -Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> -Acked-by: Stefan Wahren <stefan.wahren@i2se.com> -Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> ---- - .../staging/vc04_services/bcm2835-audio/TODO | 25 +++---------------- - 1 file changed, 3 insertions(+), 22 deletions(-) - ---- a/drivers/staging/vc04_services/bcm2835-audio/TODO -+++ b/drivers/staging/vc04_services/bcm2835-audio/TODO -@@ -4,26 +4,7 @@ - * * - ***************************************************************************** - -+1) Revisit multi-cards options and PCM route mixer control (as per comment -+https://lkml.org/lkml/2018/9/8/200) - --1) Document the device tree node -- --The downstream tree(the tree that the driver was imported from) at --http://www.github.com/raspberrypi/linux uses this node: -- --audio: audio { -- compatible = "brcm,bcm2835-audio"; -- brcm,pwm-channels = <8>; --}; -- --Since the driver requires the use of VCHIQ, it may be useful to have a link --in the device tree to the VCHIQ driver. -- --2) Gracefully handle the case where VCHIQ is missing from the device tree or --it has not been initialized yet. -- --3) Review error handling and remove duplicate code. -- --4) Cleanup the logging mechanism. The driver should probably be using the --standard kernel logging mechanisms such as dev_info, dev_dbg, and friends. -- --5) Fix the remaining checkpatch.pl errors and warnings. -+2) Fix the remaining checkpatch.pl errors and warnings. |