diff options
Diffstat (limited to 'target/linux/brcm2708/patches-4.19/950-0257-staging-bcm2835-camera-Avoid-unneeded-internal-decla.patch')
-rw-r--r-- | target/linux/brcm2708/patches-4.19/950-0257-staging-bcm2835-camera-Avoid-unneeded-internal-decla.patch | 41 |
1 files changed, 41 insertions, 0 deletions
diff --git a/target/linux/brcm2708/patches-4.19/950-0257-staging-bcm2835-camera-Avoid-unneeded-internal-decla.patch b/target/linux/brcm2708/patches-4.19/950-0257-staging-bcm2835-camera-Avoid-unneeded-internal-decla.patch new file mode 100644 index 0000000000..0cf30d9bb1 --- /dev/null +++ b/target/linux/brcm2708/patches-4.19/950-0257-staging-bcm2835-camera-Avoid-unneeded-internal-decla.patch @@ -0,0 +1,41 @@ +From bb6d0d223ef1579a13eae3cffc66db9ede83bbd1 Mon Sep 17 00:00:00 2001 +From: Nathan Chancellor <natechancellor@gmail.com> +Date: Thu, 27 Sep 2018 17:50:39 -0700 +Subject: [PATCH 257/703] staging: bcm2835-camera: Avoid unneeded internal + declaration warning + +Clang warns: + +drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: +variable 'mains_freq_qmenu' is not needed and will not be emitted +[-Wunneeded-internal-declaration] +static const s64 mains_freq_qmenu[] = { + ^ +1 warning generated. + +This is because mains_freq_qmenu is currently only used in an ARRAY_SIZE +macro, which is a compile time evaluation in this case. Avoid this by +adding mains_freq_qmenu as the imenu member of this structure, which +matches all other controls that uses the ARRAY_SIZE macro in v4l2_ctrls. +This turns out to be a no-op because V4L2_CID_MPEG_VIDEO_BITRATE_MODE is +defined as a MMAL_CONTROL_TYPE_STD_MENU, which does not pass the imenu +definition along to v4l2_ctrl_new in bm2835_mmal_init_controls. + +Link: https://github.com/ClangBuiltLinux/linux/issues/122 +Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> +Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> +--- + drivers/staging/vc04_services/bcm2835-camera/controls.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c ++++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c +@@ -1109,7 +1109,7 @@ static const struct bm2835_mmal_v4l2_ctr + { + V4L2_CID_POWER_LINE_FREQUENCY, MMAL_CONTROL_TYPE_STD_MENU, + 0, ARRAY_SIZE(mains_freq_qmenu) - 1, +- 1, 1, NULL, ++ 1, 1, mains_freq_qmenu, + MMAL_PARAMETER_FLICKER_AVOID, + &ctrl_set_flicker_avoidance, + false |