diff options
Diffstat (limited to 'target/linux/brcm2708/patches-4.19/950-0233-staging-bcm2835-camera-Remove-amend-some-obsolete-co.patch')
| -rw-r--r-- | target/linux/brcm2708/patches-4.19/950-0233-staging-bcm2835-camera-Remove-amend-some-obsolete-co.patch | 49 |
1 files changed, 49 insertions, 0 deletions
diff --git a/target/linux/brcm2708/patches-4.19/950-0233-staging-bcm2835-camera-Remove-amend-some-obsolete-co.patch b/target/linux/brcm2708/patches-4.19/950-0233-staging-bcm2835-camera-Remove-amend-some-obsolete-co.patch new file mode 100644 index 0000000000..920249e6b4 --- /dev/null +++ b/target/linux/brcm2708/patches-4.19/950-0233-staging-bcm2835-camera-Remove-amend-some-obsolete-co.patch @@ -0,0 +1,49 @@ +From 37ede4f6a1771b09dea6e8b2fc4d2c5f085a33f3 Mon Sep 17 00:00:00 2001 +From: Dave Stevenson <dave.stevenson@raspberrypi.org> +Date: Fri, 28 Sep 2018 10:22:26 +0100 +Subject: [PATCH] staging: bcm2835-camera: Remove/amend some obsolete + comments + +Remove a todo which has been done. +Remove a template line that was redundant. +Make a comment clearer as to the non-obvious meaning of a field. + +Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> +--- + .../staging/vc04_services/bcm2835-camera/controls.c | 11 +---------- + 1 file changed, 1 insertion(+), 10 deletions(-) + +--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c ++++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c +@@ -965,10 +965,6 @@ static const struct bm2835_mmal_v4l2_ctr + &ctrl_set_value, + false + }, +-/* { +- * 0, MMAL_CONTROL_TYPE_CLUSTER, 3, 1, 0, NULL, 0, NULL +- * }, +- */ + { + V4L2_CID_EXPOSURE_AUTO, MMAL_CONTROL_TYPE_STD_MENU, + ~0x03, V4L2_EXPOSURE_APERTURE_PRIORITY, V4L2_EXPOSURE_AUTO, 0, +@@ -976,11 +972,6 @@ static const struct bm2835_mmal_v4l2_ctr + &ctrl_set_exposure, + false + }, +-/* todo this needs mixing in with set exposure +- * { +- * V4L2_CID_SCENE_MODE, MMAL_CONTROL_TYPE_STD_MENU, +- * }, +- */ + { + V4L2_CID_EXPOSURE_ABSOLUTE, MMAL_CONTROL_TYPE_STD, + /* Units of 100usecs */ +@@ -1146,7 +1137,7 @@ static const struct bm2835_mmal_v4l2_ctr + }, + { + V4L2_CID_SCENE_MODE, MMAL_CONTROL_TYPE_STD_MENU, +- -1, /* Min is computed at runtime */ ++ -1, /* Min (mask) is computed at runtime */ + V4L2_SCENE_MODE_TEXT, + V4L2_SCENE_MODE_NONE, 1, NULL, + MMAL_PARAMETER_PROFILE, |