aboutsummaryrefslogtreecommitdiffstats
path: root/target
diff options
context:
space:
mode:
authorOlliver Schinagl <oliver@schinagl.nl>2022-10-27 20:53:08 +0200
committerSander Vanheule <sander@svanheule.net>2022-10-29 11:18:04 +0200
commitf4849c0ab7c4cb29a85667f2c16aaa73bbfa4315 (patch)
tree237c818cc47fdad94c3d3fd4be88e71052e4f9a0 /target
parent5384c9337f2323727081e32369a86b62e72c47d8 (diff)
downloadupstream-f4849c0ab7c4cb29a85667f2c16aaa73bbfa4315.tar.gz
upstream-f4849c0ab7c4cb29a85667f2c16aaa73bbfa4315.tar.bz2
upstream-f4849c0ab7c4cb29a85667f2c16aaa73bbfa4315.zip
realtek: Fix CRC offloading for rtl83xx
In rtl83xx_set_features we set bit 3 to enable, and bit 4 to disable checksuming. Looking at rtl93xx_set_features we however see that for both enable and disable the same bit is used (bit 4). This can't be right, especially as bit 4 for rtl83xx seems to be Collision threshold occupying 2 bits. Change this to make this more logical. Fixes: 9e8d62e42117 ("realtek: enable CRC offloading") Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Diffstat (limited to 'target')
-rw-r--r--target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c b/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c
index f5424bbfa3..be84549b9e 100644
--- a/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c
+++ b/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c
@@ -2247,7 +2247,7 @@ static int rtl83xx_set_features(struct net_device *dev, netdev_features_t featur
if (!(features & NETIF_F_RXCSUM))
sw_w32_mask(BIT(3), 0, priv->r->mac_port_ctrl(priv->cpu_port));
else
- sw_w32_mask(0, BIT(4), priv->r->mac_port_ctrl(priv->cpu_port));
+ sw_w32_mask(0, BIT(3), priv->r->mac_port_ctrl(priv->cpu_port));
}
return 0;