aboutsummaryrefslogtreecommitdiffstats
path: root/target
diff options
context:
space:
mode:
authorGabor Juhos <juhosg@openwrt.org>2010-07-15 13:04:57 +0000
committerGabor Juhos <juhosg@openwrt.org>2010-07-15 13:04:57 +0000
commite215d60a70050f82b8f1802bfdcb9431fb2ecd4d (patch)
treef79248e758595a657ffe17720ea3fddb05fa5df3 /target
parent6d1ca0acf0d412e1fcafd0a6a3f8dddcd99e37f4 (diff)
downloadupstream-e215d60a70050f82b8f1802bfdcb9431fb2ecd4d.tar.gz
upstream-e215d60a70050f82b8f1802bfdcb9431fb2ecd4d.tar.bz2
upstream-e215d60a70050f82b8f1802bfdcb9431fb2ecd4d.zip
generic: rtl8366: use SWITCH_TYPE_NOVAL for reset_mib attributes
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@22191 3c298f89-4303-0410-b956-a3cf2f4a3e73
Diffstat (limited to 'target')
-rw-r--r--target/linux/generic/files/drivers/net/phy/rtl8366rb.c16
-rw-r--r--target/linux/generic/files/drivers/net/phy/rtl8366s.c14
2 files changed, 7 insertions, 23 deletions
diff --git a/target/linux/generic/files/drivers/net/phy/rtl8366rb.c b/target/linux/generic/files/drivers/net/phy/rtl8366rb.c
index 420a5523cf..ceae5409e4 100644
--- a/target/linux/generic/files/drivers/net/phy/rtl8366rb.c
+++ b/target/linux/generic/files/drivers/net/phy/rtl8366rb.c
@@ -677,13 +677,9 @@ static int rtl8366rb_sw_reset_mibs(struct switch_dev *dev,
struct switch_val *val)
{
struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
- int err = 0;
- if (val->value.i == 1)
- err = rtl8366_smi_rmwr(smi, RTL8366RB_MIB_CTRL_REG, 0,
- RTL8366RB_MIB_CTRL_GLOBAL_RESET);
-
- return err;
+ return rtl8366_smi_rmwr(smi, RTL8366RB_MIB_CTRL_REG, 0,
+ RTL8366RB_MIB_CTRL_GLOBAL_RESET);
}
static int rtl8366rb_sw_get_vlan_enable(struct switch_dev *dev,
@@ -1032,12 +1028,10 @@ static struct switch_attr rtl8366rb_globals[] = {
.max = 1,
.ofs = 2
}, {
- .type = SWITCH_TYPE_INT,
+ .type = SWITCH_TYPE_NOVAL,
.name = "reset_mibs",
.description = "Reset all MIB counters",
.set = rtl8366rb_sw_reset_mibs,
- .get = NULL,
- .max = 1
}, {
.type = SWITCH_TYPE_INT,
.name = "blinkrate",
@@ -1058,12 +1052,10 @@ static struct switch_attr rtl8366rb_port[] = {
.set = NULL,
.get = rtl8366rb_sw_get_port_link,
}, {
- .type = SWITCH_TYPE_INT,
+ .type = SWITCH_TYPE_NOVAL,
.name = "reset_mib",
.description = "Reset single port MIB counters",
- .max = 1,
.set = rtl8366rb_sw_reset_port_mibs,
- .get = NULL,
}, {
.type = SWITCH_TYPE_STRING,
.name = "mib",
diff --git a/target/linux/generic/files/drivers/net/phy/rtl8366s.c b/target/linux/generic/files/drivers/net/phy/rtl8366s.c
index 45da8fd8e5..5672c42f75 100644
--- a/target/linux/generic/files/drivers/net/phy/rtl8366s.c
+++ b/target/linux/generic/files/drivers/net/phy/rtl8366s.c
@@ -664,12 +664,8 @@ static int rtl8366s_sw_reset_mibs(struct switch_dev *dev,
struct switch_val *val)
{
struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
- int err = 0;
- if (val->value.i == 1)
- err = rtl8366_smi_rmwr(smi, RTL8366S_MIB_CTRL_REG, 0, (1 << 2));
-
- return err;
+ return rtl8366_smi_rmwr(smi, RTL8366S_MIB_CTRL_REG, 0, (1 << 2));
}
static int rtl8366s_sw_get_vlan_enable(struct switch_dev *dev,
@@ -1020,12 +1016,10 @@ static struct switch_attr rtl8366s_globals[] = {
.max = 1,
.ofs = 2
}, {
- .type = SWITCH_TYPE_INT,
+ .type = SWITCH_TYPE_NOVAL,
.name = "reset_mibs",
.description = "Reset all MIB counters",
.set = rtl8366s_sw_reset_mibs,
- .get = NULL,
- .max = 1
}, {
.type = SWITCH_TYPE_INT,
.name = "blinkrate",
@@ -1046,12 +1040,10 @@ static struct switch_attr rtl8366s_port[] = {
.set = NULL,
.get = rtl8366s_sw_get_port_link,
}, {
- .type = SWITCH_TYPE_INT,
+ .type = SWITCH_TYPE_NOVAL,
.name = "reset_mib",
.description = "Reset single port MIB counters",
- .max = 1,
.set = rtl8366s_sw_reset_port_mibs,
- .get = NULL,
}, {
.type = SWITCH_TYPE_STRING,
.name = "mib",