diff options
| author | John Crispin <john@openwrt.org> | 2016-03-10 19:10:54 +0000 |
|---|---|---|
| committer | John Crispin <john@openwrt.org> | 2016-03-10 19:10:54 +0000 |
| commit | 01ca7a34f08856331f426c0e34d06d738e150b17 (patch) | |
| tree | e937e1a4a60948a23a95e6b56eaceaddd6d31006 /target/linux | |
| parent | b2348e69ad1d228d4ac32f5a19246439d9960d9b (diff) | |
| download | upstream-01ca7a34f08856331f426c0e34d06d738e150b17.tar.gz upstream-01ca7a34f08856331f426c0e34d06d738e150b17.tar.bz2 upstream-01ca7a34f08856331f426c0e34d06d738e150b17.zip | |
brcm63xx/lzma-loader: fix O32 ABI conformance
According to the calling convention of the o32 ABI the caller
function must reserve stack space for $a0-$a3 registers in case
the callee needs to save its arguments.
The assembly code of the loader does not reserve stack space for
these registers thus when the 'loader_main' function needs to save
its arguments, those will be stored in the 'workspace' area instead
of the stack.
Because the workspace area is also used by other part of the code, the
saved register values gets overwritten and this often leads to failed
kernel boots.
Fix the code to reserve stack space for the registers to avoid this
error.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
[noltari: apply the fix for brcm63xx too]
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
SVN-Revision: 48979
Diffstat (limited to 'target/linux')
| -rw-r--r-- | target/linux/brcm63xx/image/lzma-loader/src/head.S | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/target/linux/brcm63xx/image/lzma-loader/src/head.S b/target/linux/brcm63xx/image/lzma-loader/src/head.S index 543996a0da..47a7c9bd63 100644 --- a/target/linux/brcm63xx/image/lzma-loader/src/head.S +++ b/target/linux/brcm63xx/image/lzma-loader/src/head.S @@ -109,6 +109,9 @@ __bss_check: /* Setup new "C" stack */ la sp, _stack + /* reserve stack space for a0-a3 registers */ + subu sp, 16 + /* jump to the decompressor routine */ la t0, loader_main jr t0 |