diff options
| author | Olliver Schinagl <oliver@schinagl.nl> | 2022-12-22 11:53:30 +0100 |
|---|---|---|
| committer | Sander Vanheule <sander@svanheule.net> | 2022-12-27 16:33:15 +0100 |
| commit | 0a83889e89b7213ea8f6eac21de50ffa3ae5a606 (patch) | |
| tree | 2cbdc779663e8eb848cbe3242bc5923c3922491f /target/linux/realtek/files-5.15/drivers/i2c | |
| parent | 94d8b4852b9ff0063cddfda13a96fb5449f3bd6d (diff) | |
| download | upstream-0a83889e89b7213ea8f6eac21de50ffa3ae5a606.tar.gz upstream-0a83889e89b7213ea8f6eac21de50ffa3ae5a606.tar.bz2 upstream-0a83889e89b7213ea8f6eac21de50ffa3ae5a606.zip | |
realtek: Reduce variable scopes
Linus prefers to have loop initializers nice and tightly scoped. In
OpenWRT this has been possible since 41a1a652fbd4 ("kernel: backport
gnu11 upgrade").
This patch cleans up variable scope while trying to do the above for
'simple for loops'.
This cleans up and simplifies some functions and code, and pulls in
variables to a smaller scope.
Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Diffstat (limited to 'target/linux/realtek/files-5.15/drivers/i2c')
| -rw-r--r-- | target/linux/realtek/files-5.15/drivers/i2c/busses/i2c-rtl9300.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/target/linux/realtek/files-5.15/drivers/i2c/busses/i2c-rtl9300.c b/target/linux/realtek/files-5.15/drivers/i2c/busses/i2c-rtl9300.c index 9afd2f823e..54d916d17a 100644 --- a/target/linux/realtek/files-5.15/drivers/i2c/busses/i2c-rtl9300.c +++ b/target/linux/realtek/files-5.15/drivers/i2c/busses/i2c-rtl9300.c @@ -123,13 +123,12 @@ static int rtl9310_i2c_config_xfer(struct rtl9300_i2c *i2c, u16 addr, u16 len) static int i2c_read(void __iomem *r0, u8 *buf, int len) { - int i; - u32 v; - if (len > 16) return -EIO; - for (i = 0; i < len; i++) { + for (int i = 0; i < len; i++) { + u32 v; + if (i % 4 == 0) v = readl(r0 + i); buf[i] = v; @@ -141,13 +140,12 @@ static int i2c_read(void __iomem *r0, u8 *buf, int len) static int i2c_write(void __iomem *r0, u8 *buf, int len) { - u32 v; - int i; - if (len > 16) return -EIO; - for (i = 0; i < len; i++) { + for (int i = 0; i < len; i++) { + u32 v; + if (! (i % 4)) v = 0; v <<= 8; |