aboutsummaryrefslogtreecommitdiffstats
path: root/target/linux/ramips
diff options
context:
space:
mode:
authorWei Yongjun <weiyongjun1@huawei.com>2018-05-14 11:14:24 -0700
committerJohn Crispin <john@phrozen.org>2018-05-15 06:45:53 +0200
commitedec25187008e2e7893858f871369f9d6a0157e0 (patch)
treea893e4a80ab73252c8257d70e8bdb076c8011b55 /target/linux/ramips
parentc4ae54dfabc982d9b8865984b91e493745da12e2 (diff)
downloadupstream-edec25187008e2e7893858f871369f9d6a0157e0.tar.gz
upstream-edec25187008e2e7893858f871369f9d6a0157e0.tar.bz2
upstream-edec25187008e2e7893858f871369f9d6a0157e0.zip
staging: mt7621-eth: fix return value check in mtk_connect_phy_node()
In case of error, the function of_phy_connect() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: e3cbf478f846 ("staging: mt7621-eth: add the drivers core files") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'target/linux/ramips')
-rw-r--r--target/linux/ramips/files-4.14/drivers/net/ethernet/mtk/mdio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/target/linux/ramips/files-4.14/drivers/net/ethernet/mtk/mdio.c b/target/linux/ramips/files-4.14/drivers/net/ethernet/mtk/mdio.c
index b2a31589bc..bdfdf7a432 100644
--- a/target/linux/ramips/files-4.14/drivers/net/ethernet/mtk/mdio.c
+++ b/target/linux/ramips/files-4.14/drivers/net/ethernet/mtk/mdio.c
@@ -82,10 +82,10 @@ int fe_connect_phy_node(struct fe_priv *priv, struct device_node *phy_node)
phydev = of_phy_connect(priv->netdev, phy_node, fe_phy_link_adjust,
0, phy_mode);
- if (IS_ERR(phydev)) {
+ if (!phydev) {
dev_err(priv->dev, "could not connect to PHY\n");
priv->phy->phy_node[port] = NULL;
- return PTR_ERR(phydev);
+ return -ENODEV;
}
phydev->supported &= PHY_GBIT_FEATURES;