aboutsummaryrefslogtreecommitdiffstats
path: root/target/linux/ramips/mt76x8
diff options
context:
space:
mode:
authorAdrian Schmutzler <freifunk@adrianschmutzler.de>2020-09-27 23:35:11 +0200
committerAdrian Schmutzler <freifunk@adrianschmutzler.de>2020-10-02 14:51:57 +0200
commit2230fe39229364f71b982acebedab0579f8b4165 (patch)
treecd2ba296872a224970207ba37771f4d35db8120e /target/linux/ramips/mt76x8
parented5933beb632cd29869b81c04d7fa937a27d1a2f (diff)
downloadupstream-2230fe39229364f71b982acebedab0579f8b4165.tar.gz
upstream-2230fe39229364f71b982acebedab0579f8b4165.tar.bz2
upstream-2230fe39229364f71b982acebedab0579f8b4165.zip
ramips: remove set_wifi_led function in 01_leds
While we mostly use the ucidef_set_led_* functions directly in 01_leds we still have the set_wifi_led function in parallel for several old devices. This is not only inconsistent with the other definitions, it also links to the wlan0 interface instead of using a phy trigger which would be independent of the interface name (and is used for all newer devices anyway). Apart from that, the standard names "wifi" and "wifi-led" are not very helpful in a world with different radio bands either. Thus, this patch removes the set_wifi_led function and puts the relevant commands into the cases explicitly. This makes the mechanism used more evident and will hopefully lead to some future improvements or at least prevent some copy-pasting of the old setups. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
Diffstat (limited to 'target/linux/ramips/mt76x8')
-rwxr-xr-xtarget/linux/ramips/mt76x8/base-files/etc/board.d/01_leds20
1 files changed, 8 insertions, 12 deletions
diff --git a/target/linux/ramips/mt76x8/base-files/etc/board.d/01_leds b/target/linux/ramips/mt76x8/base-files/etc/board.d/01_leds
index befb4a78e8..c26d6436e9 100755
--- a/target/linux/ramips/mt76x8/base-files/etc/board.d/01_leds
+++ b/target/linux/ramips/mt76x8/base-files/etc/board.d/01_leds
@@ -3,17 +3,13 @@
. /lib/functions/leds.sh
. /lib/functions/uci-defaults.sh
-set_wifi_led() {
- ucidef_set_led_netdev "wifi_led" "wifi" "${1}" "${2:-wlan0}"
-}
-
board=$(board_name)
board_config_update
case $board in
alfa-network,awusfree1)
- set_wifi_led "blue:wlan"
+ ucidef_set_led_netdev "wifi_led" "wifi" "blue:wlan" "wlan0"
;;
asus,rt-n10p-v3|\
asus,rt-n11p-b1|\
@@ -30,12 +26,12 @@ cudy,wr1000)
ucidef_set_led_switch "lan2" "lan2" "blue:lan2" "switch0" "0x04"
;;
glinet,gl-mt300n-v2)
- set_wifi_led "red:wlan"
+ ucidef_set_led_netdev "wifi_led" "wifi" "red:wlan" "wlan0"
ucidef_set_led_switch "wan" "wan" "green:wan" "switch0" "0x1"
;;
hilink,hlk-7628n|\
skylab,skw92a)
- set_wifi_led "green:wlan"
+ ucidef_set_led_netdev "wifi_led" "wifi" "green:wlan" "wlan0"
;;
hiwifi,hc5661a|\
hiwifi,hc5761a)
@@ -45,7 +41,7 @@ mediatek,linkit-smart-7688)
ucidef_set_led_wlan "wifi" "wifi" "orange:wifi" "phy0tpt"
;;
rakwireless,rak633)
- set_wifi_led "blue:wifi"
+ ucidef_set_led_netdev "wifi_led" "wifi" "blue:wifi" "wlan0"
;;
tama,w06)
ucidef_set_led_netdev "wan" "WAN" "green:wan" "eth0"
@@ -102,7 +98,7 @@ unielec,u7628-01-16m)
ucidef_set_led_switch "lan3" "lan3" "green:lan3" "switch0" "0x8"
ucidef_set_led_switch "lan4" "lan4" "green:lan4" "switch0" "0x10"
ucidef_set_led_switch "wan" "wan" "green:wan" "switch0" "0x01"
- set_wifi_led "green:wlan"
+ ucidef_set_led_netdev "wifi_led" "wifi" "green:wlan" "wlan0"
;;
wavlink,wl-wn570ha1)
ucidef_set_led_switch "wan" "wan" "green:wan" "switch0" "0x01"
@@ -110,7 +106,7 @@ wavlink,wl-wn570ha1)
ucidef_set_led_rssi "wifi-low" "wifi-low" "green:wifi-low" "wlan0" "1" "49"
ucidef_set_led_rssi "wifi-med" "wifi-med" "green:wifi-med" "wlan0" "50" "84"
ucidef_set_led_rssi "wifi-high" "wifi-high" "green:wifi-high" "wlan0" "85" "100"
- set_wifi_led "green:wifi"
+ ucidef_set_led_netdev "wifi_led" "wifi" "green:wifi" "wlan0"
;;
wavlink,wl-wn575a3)
ucidef_set_rssimon "wlan1" "200000" "1"
@@ -123,13 +119,13 @@ wavlink,wl-wn577a2)
ucidef_set_led_switch "wan" "wan" "green:wan" "switch0" "0x10"
;;
zbtlink,zbt-we1226)
- set_wifi_led "green:wlan"
+ ucidef_set_led_netdev "wifi_led" "wifi" "green:wlan" "wlan0"
ucidef_set_led_switch "lan1" "LAN1" "green:lan1" "switch0" "0x01"
ucidef_set_led_switch "lan2" "LAN2" "green:lan2" "switch0" "0x02"
ucidef_set_led_switch "wan" "WAN" "green:wan" "switch0" "0x10"
;;
zyxel,keenetic-extra-ii)
- set_wifi_led "green:wifi"
+ ucidef_set_led_netdev "wifi_led" "wifi" "green:wifi" "wlan0"
ucidef_set_led_switch "internet" "internet" "green:internet" "switch0" "0x01"
;;
esac