diff options
author | Adrian Schmutzler <freifunk@adrianschmutzler.de> | 2019-12-22 16:51:19 +0100 |
---|---|---|
committer | Adrian Schmutzler <freifunk@adrianschmutzler.de> | 2019-12-27 18:00:06 +0100 |
commit | 09d38a3bc328d122b0d84fcf6bb53d2bce7373b6 (patch) | |
tree | 3b59e06f5fbf2213b67cb904bd100fa7084229d5 /target/linux/generic/pending-4.14/646-netfilter-nf_flow_table-rework-private-driver-data.patch | |
parent | ea980fb9c6de24350976dcc6c20da2bed5fc8cb8 (diff) | |
download | upstream-09d38a3bc328d122b0d84fcf6bb53d2bce7373b6.tar.gz upstream-09d38a3bc328d122b0d84fcf6bb53d2bce7373b6.tar.bz2 upstream-09d38a3bc328d122b0d84fcf6bb53d2bce7373b6.zip |
ramips: remove bogus ralink,mtd-eeprom with offset 0x4
Several devices in mt76x8 subtarget use the following line to set
up wmac in their DTS(I) files:
ralink,mtd-eeprom = <&factory 0x4>
This is strange for several reasons:
- They should use mediatek,mtd-eeprom on this SOC
- The caldata is supposed to start at 0x0
- The parent DTSI mt7628an.dtsi specifies mediatek,mtd-eeprom anyway,
starting from 0x0
- The offset coincides with the default location of the MAC address
in caldata
Based on the comment in b28e94d4bfa1 ("ramips: MiWiFi Nano fixes"),
it looks like the author for this device wanted to actually use
mtd-mac-address instead of ralink,mtd-eeprom. A check on the same
device revealed that actually the MAC address start at offset 4 there,
so the correct caldata offset is 0x0.
Based on these findings, and the fact that the expected location on
this SOC is 0x0, we remove the "ralink,mtd-eeprom = <&factory 0x4>"
statement from all devices in ramips (being only mt7628an anyway).
Thanks to Sungbo Eo for finding and researching this.
Reported-by: Sungbo Eo <mans0n@gorani.run>
Fixes: b28e94d4bfa1 ("ramips: MiWiFi Nano fixes")
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
Diffstat (limited to 'target/linux/generic/pending-4.14/646-netfilter-nf_flow_table-rework-private-driver-data.patch')
0 files changed, 0 insertions, 0 deletions