diff options
author | Rafał Miłecki <rafal@milecki.pl> | 2021-10-04 07:12:36 +0200 |
---|---|---|
committer | Rafał Miłecki <rafal@milecki.pl> | 2021-10-07 11:30:55 +0200 |
commit | b2cfed48f62622efa8577372942bbc268afe4677 (patch) | |
tree | d0144aea071604a54bb8bfb87e9c195e5190d292 /target/linux/generic/files/drivers/net/phy/swconfig.c | |
parent | fd71ef34b75c81646d17d21d80dc3a5b5e2e6bb8 (diff) | |
download | upstream-b2cfed48f62622efa8577372942bbc268afe4677.tar.gz upstream-b2cfed48f62622efa8577372942bbc268afe4677.tar.bz2 upstream-b2cfed48f62622efa8577372942bbc268afe4677.zip |
Revert "swconfig: fix Broadcom b53 support"
This reverts commit 8f9cd1af0f9c325a902dbd0e79e12015372e6bb0.
That commit was meant to add a single EXPORT_SYMBOL_GPL() but it
actually also added few .of_match_table-s. One commit should handle one
thing and should not introduce unrelated changes.
Regarding actual changes:
1. EXPORT_SYMBOL_GPL is not required as we don't build swconfig drivers
as modules.
2. PHY drivers must not have .of_match_table. That is allowed for MDIO
drivers. This could work for some time (although is didn't for me on
bcm53xx) but does not with kernel 5.10. It causes a soft lockup and
upstream developers confirmed it's an unsupported design.
Link: https://lore.kernel.org/netdev/2b1dc053-8c9a-e3e4-b450-eecdfca3fe16@gmail.com/t/#mf80e472f35ee23f7a75cbf5b1e101a17ab3a64a3
Cc: Tobias Schramm <tobleminer@gmail.com>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Diffstat (limited to 'target/linux/generic/files/drivers/net/phy/swconfig.c')
-rw-r--r-- | target/linux/generic/files/drivers/net/phy/swconfig.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/target/linux/generic/files/drivers/net/phy/swconfig.c b/target/linux/generic/files/drivers/net/phy/swconfig.c index a734e57608..f506daaf91 100644 --- a/target/linux/generic/files/drivers/net/phy/swconfig.c +++ b/target/linux/generic/files/drivers/net/phy/swconfig.c @@ -1222,7 +1222,6 @@ switch_generic_set_link(struct switch_dev *dev, int port, return 0; } -EXPORT_SYMBOL_GPL(switch_generic_set_link); static int __init swconfig_init(void) |