diff options
author | Rafał Miłecki <rafal@milecki.pl> | 2019-03-06 06:00:00 +0100 |
---|---|---|
committer | Rafał Miłecki <rafal@milecki.pl> | 2019-03-06 06:08:15 +0100 |
commit | eea538204bb973d73d3bc3d38947d7f85214d486 (patch) | |
tree | 3ffe2b4db30664cdd5d3ed7b90b07f5bc9f0e6c5 /target/linux/generic/backport-4.9 | |
parent | f1803e349297d82fa7b7eaac302db653ed5dc868 (diff) | |
download | upstream-eea538204bb973d73d3bc3d38947d7f85214d486.tar.gz upstream-eea538204bb973d73d3bc3d38947d7f85214d486.tar.bz2 upstream-eea538204bb973d73d3bc3d38947d7f85214d486.zip |
kernel: fix refcnt leak in LED netdev trigger on interface rename
Renaming a netdev-trigger-tracked interface was resulting in an
unbalanced dev_hold().
Example:
> iw phy phy0 interface add foo type __ap
> echo netdev > trigger
> echo foo > device_name
> ip link set foo name bar
> iw dev bar del
[ 237.355366] unregister_netdevice: waiting for bar to become free. Usage count = 1
[ 247.435362] unregister_netdevice: waiting for bar to become free. Usage count = 1
[ 257.545366] unregister_netdevice: waiting for bar to become free. Usage count = 1
Above problem was caused by trigger checking a dev->name which obviously
changes after renaming an interface. It meant missing all further events
including the NETDEV_UNREGISTER which is required for calling dev_put().
This change fixes that by:
1) Comparing device struct *address* for notification-filtering purposes
2) Dropping unneeded NETDEV_CHANGENAME code (no behavior change)
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Diffstat (limited to 'target/linux/generic/backport-4.9')
0 files changed, 0 insertions, 0 deletions