diff options
| author | Álvaro Fernández Rojas <noltari@gmail.com> | 2019-07-09 20:32:28 +0200 |
|---|---|---|
| committer | Álvaro Fernández Rojas <noltari@gmail.com> | 2019-07-14 12:44:14 +0200 |
| commit | 42954857190b9df16d9d873ecc7f6cc38e013e44 (patch) | |
| tree | 98c588f629ff534d458eb0884782ea99672d7634 /target/linux/brcm2708/patches-4.19/950-0301-lan78xx-Debounce-link-events-to-minimize-poll-storm.patch | |
| parent | f1875e902d0afb7d9b9e5285b4fd8da7f6c5e30a (diff) | |
| download | upstream-42954857190b9df16d9d873ecc7f6cc38e013e44.tar.gz upstream-42954857190b9df16d9d873ecc7f6cc38e013e44.tar.bz2 upstream-42954857190b9df16d9d873ecc7f6cc38e013e44.zip | |
brcm2708: add linux 4.19 support
Boot tested on Raspberry Pi B+ (BCM2708) and Raspberry Pi 2 (BCM2709)
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Diffstat (limited to 'target/linux/brcm2708/patches-4.19/950-0301-lan78xx-Debounce-link-events-to-minimize-poll-storm.patch')
| -rw-r--r-- | target/linux/brcm2708/patches-4.19/950-0301-lan78xx-Debounce-link-events-to-minimize-poll-storm.patch | 44 |
1 files changed, 44 insertions, 0 deletions
diff --git a/target/linux/brcm2708/patches-4.19/950-0301-lan78xx-Debounce-link-events-to-minimize-poll-storm.patch b/target/linux/brcm2708/patches-4.19/950-0301-lan78xx-Debounce-link-events-to-minimize-poll-storm.patch new file mode 100644 index 0000000000..f5ca286e73 --- /dev/null +++ b/target/linux/brcm2708/patches-4.19/950-0301-lan78xx-Debounce-link-events-to-minimize-poll-storm.patch @@ -0,0 +1,44 @@ +From 643d2b5c276c5d2967b857256a983ae7860607a1 Mon Sep 17 00:00:00 2001 +From: Joshua Emele <jemele@acm.org> +Date: Wed, 7 Nov 2018 16:07:40 -0800 +Subject: [PATCH 301/703] lan78xx: Debounce link events to minimize poll storm + +The bInterval is set to 4 (i.e. 8 microframes => 1ms) and the only bit +that the driver pays attention to is "link was reset". If there's a +flapping status bit in that endpoint data, (such as if PHY negotiation +needs a few tries to get a stable link) then polling at a slower rate +would act as a de-bounce. + +See: https://github.com/raspberrypi/linux/issues/2447 +--- + drivers/net/usb/lan78xx.c | 12 +++++++++++- + 1 file changed, 11 insertions(+), 1 deletion(-) + +--- a/drivers/net/usb/lan78xx.c ++++ b/drivers/net/usb/lan78xx.c +@@ -448,6 +448,11 @@ static bool enable_tso; + module_param(enable_tso, bool, 0644); + MODULE_PARM_DESC(enable_tso, "Enables TCP segmentation offload"); + ++#define INT_URB_MICROFRAMES_PER_MS 8 ++static int int_urb_interval_ms = 8; ++module_param(int_urb_interval_ms, int, 0); ++MODULE_PARM_DESC(int_urb_interval_ms, "Override usb interrupt urb interval"); ++ + static int lan78xx_read_reg(struct lan78xx_net *dev, u32 index, u32 *data) + { + u32 *buf = kmalloc(sizeof(u32), GFP_KERNEL); +@@ -3816,7 +3821,12 @@ static int lan78xx_probe(struct usb_inte + dev->pipe_intr = usb_rcvintpipe(dev->udev, + dev->ep_intr->desc.bEndpointAddress & + USB_ENDPOINT_NUMBER_MASK); +- period = dev->ep_intr->desc.bInterval; ++ if (int_urb_interval_ms <= 0) ++ period = dev->ep_intr->desc.bInterval; ++ else ++ period = int_urb_interval_ms * INT_URB_MICROFRAMES_PER_MS; ++ ++ netif_notice(dev, probe, netdev, "int urb period %d\n", period); + + maxp = usb_maxpacket(dev->udev, dev->pipe_intr, 0); + buf = kmalloc(maxp, GFP_KERNEL); |