aboutsummaryrefslogtreecommitdiffstats
path: root/target/linux/ar71xx
diff options
context:
space:
mode:
authorGabor Juhos <juhosg@openwrt.org>2010-01-20 09:30:32 +0000
committerGabor Juhos <juhosg@openwrt.org>2010-01-20 09:30:32 +0000
commite58b6f9e1159571d02337b52783585e70f527264 (patch)
tree258ffec62f23a3954c49604403d454a48da7b8da /target/linux/ar71xx
parent95ccf9e5dd9d95e15415c47213e4718d2e32ab23 (diff)
downloadupstream-e58b6f9e1159571d02337b52783585e70f527264.tar.gz
upstream-e58b6f9e1159571d02337b52783585e70f527264.tar.bz2
upstream-e58b6f9e1159571d02337b52783585e70f527264.zip
rtl8366_smi: fix error checking in rtl8366s_set_vlan_4k_entry
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@19242 3c298f89-4303-0410-b956-a3cf2f4a3e73
Diffstat (limited to 'target/linux/ar71xx')
-rw-r--r--target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c b/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
index 46069067e7..1043b3d44e 100644
--- a/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
+++ b/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
@@ -671,16 +671,16 @@ static int rtl8366s_set_vlan_4k_entry(struct rtl8366_smi *smi,
data = *tableaddr;
- rtl8366_smi_write_reg(smi, RTL8366S_VLAN_TABLE_WRITE_BASE + 1, data);
-
+ err = rtl8366_smi_write_reg(smi, RTL8366S_VLAN_TABLE_WRITE_BASE + 1,
+ data);
+ if (err)
+ return err;
/* write table access control word */
err = rtl8366_smi_write_reg(smi, RTL8366S_TABLE_ACCESS_CTRL_REG,
RTL8366S_TABLE_VLAN_WRITE_CTRL);
- if (err)
- return err;
- return 0;
+ return err;
}
static int rtl8366s_get_vlan_member_config(struct rtl8366_smi *smi, u32 index,