aboutsummaryrefslogtreecommitdiffstats
path: root/target/linux/adm5120/files/drivers
diff options
context:
space:
mode:
authorFlorian Fainelli <florian@openwrt.org>2007-11-01 17:11:16 +0000
committerFlorian Fainelli <florian@openwrt.org>2007-11-01 17:11:16 +0000
commit647541a1a0f6e333f1ccad1a49eeb62937edfef8 (patch)
treeccb955358a88cb96f81b22d7af00a952dc87595f /target/linux/adm5120/files/drivers
parent772c6488da203a2d3af523cc3b4a2378a2a1ae12 (diff)
downloadupstream-647541a1a0f6e333f1ccad1a49eeb62937edfef8.tar.gz
upstream-647541a1a0f6e333f1ccad1a49eeb62937edfef8.tar.bz2
upstream-647541a1a0f6e333f1ccad1a49eeb62937edfef8.zip
CF driver cleanup
SVN-Revision: 9473
Diffstat (limited to 'target/linux/adm5120/files/drivers')
-rw-r--r--target/linux/adm5120/files/drivers/block/rb1xx/ata.c9
-rw-r--r--target/linux/adm5120/files/drivers/block/rb1xx/bdev.c13
2 files changed, 13 insertions, 9 deletions
diff --git a/target/linux/adm5120/files/drivers/block/rb1xx/ata.c b/target/linux/adm5120/files/drivers/block/rb1xx/ata.c
index b396317f5f..5447be5219 100644
--- a/target/linux/adm5120/files/drivers/block/rb1xx/ata.c
+++ b/target/linux/adm5120/files/drivers/block/rb1xx/ata.c
@@ -16,8 +16,9 @@
#include <linux/pci.h>
#include <linux/ioport.h> /* request_mem_region() */
-#include <asm/unaligned.h> /* ioremap() */
-#include <asm/io.h> /* ioremap() */
+#include <asm/unaligned.h>
+#include <asm/io.h>
+#include <asm/gpio.h>
#include <gpio.h>
#include <adm5120_defs.h>
@@ -69,7 +70,7 @@ static inline u8 rareg(unsigned reg, struct cf_mips_dev* dev)
static inline int cfrdy(struct cf_mips_dev *dev)
{
- return (SW_READ_REG(GPIO_CONF0) & (1 << 12));
+ return gpio_get_value(12);
}
static inline void prepare_cf_irq(struct cf_mips_dev *dev)
@@ -92,7 +93,7 @@ static inline int cf_present(struct cf_mips_dev* dev)
int i;
/* on RB100 WAIT is LOW all the time => read will hang */
- if (SW_READ_REG(GPIO_CONF0) & (1 << 8))
+ if (gpio_read_value(8))
cmd |= EXTIO_WAIT_EN;
SW_WRITE_REG(GPIO_CONF2, cmd);
diff --git a/target/linux/adm5120/files/drivers/block/rb1xx/bdev.c b/target/linux/adm5120/files/drivers/block/rb1xx/bdev.c
index 12c938505b..bf63d206b1 100644
--- a/target/linux/adm5120/files/drivers/block/rb1xx/bdev.c
+++ b/target/linux/adm5120/files/drivers/block/rb1xx/bdev.c
@@ -93,10 +93,10 @@ int cf_mips_probe(struct platform_device *pdev)
return reg_result;
}
- dev = (struct cf_mips_dev *)kmalloc(sizeof(struct cf_mips_dev),GFP_KERNEL);
+ dev = (struct cf_mips_dev *)kzalloc(sizeof(struct cf_mips_dev),GFP_KERNEL);
if (!dev)
goto out_err;
- memset(dev, 0, sizeof(struct cf_mips_dev));
+
cdev->dev = dev;
dev->pin = cdev->gpio_pin;
@@ -104,8 +104,9 @@ int cf_mips_probe(struct platform_device *pdev)
r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cf_membase");
dev->base = (void *) r->start;
- if (cf_init(dev)) goto out_err;
- printk("init done");
+ if (cf_init(dev))
+ goto out_err;
+ printk(KERN_INFO "cf-mips: init done");
spin_lock_init(&dev->lock);
dev->queue = blk_init_queue(cf_request,&dev->lock);
@@ -125,7 +126,9 @@ int cf_mips_probe(struct platform_device *pdev)
dev->gd = alloc_disk(CF_MAX_PART);
cf_gendisk = dev->gd;
cdev->gd = dev->gd;
- if (!cf_gendisk) goto out_err; /* Last of these goto's */
+
+ if (!cf_gendisk)
+ goto out_err; /* Last of these goto's */
cf_gendisk->major = MAJOR_NR;
cf_gendisk->first_minor = 0;