diff options
| author | Rosen Penev <rosenp@gmail.com> | 2019-08-31 18:50:48 -0700 |
|---|---|---|
| committer | Stijn Tintel <stijn@linux-ipv6.be> | 2020-05-08 03:32:52 +0300 |
| commit | 73fa1aba94f5cf566007ac18cee3ef08b3ae64bc (patch) | |
| tree | 12d94da20915031cd34260409e6355c8e05b66b7 /package/network/services/samba36/patches/120-add_missing_ifdef.patch | |
| parent | 79da9d78b98e1cd4574a37e2c4c5f8315b91563d (diff) | |
| download | upstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.tar.gz upstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.tar.bz2 upstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.zip | |
samba36: Remove
Samba 3.6 is completely unsupported, in addition to having tons of patches
It also causes kernel panics on some platforms when sendfile is enabled.
Example:
https://github.com/gnubee-git/GnuBee_Docs/issues/45
I have reproduced on ramips as well as mvebu in the past.
Samba 4 is an alternative available in the packages repo.
cifsd is a lightweight alternative available in the packages repo. It is
also a faster alternative to both Samba versions (lower CPU usage). It
was renamed to ksmbd.
To summarize, here are the alternatives:
- ksmbd + luci-app-cifsd
- samba4 + luci-app-samba4
Signed-off-by: Rosen Penev <rosenp@gmail.com>
[drop samba36-server from GEMINI_NAS_PACKAGES, ksmbd rename + summary]
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Diffstat (limited to 'package/network/services/samba36/patches/120-add_missing_ifdef.patch')
| -rw-r--r-- | package/network/services/samba36/patches/120-add_missing_ifdef.patch | 41 |
1 files changed, 0 insertions, 41 deletions
diff --git a/package/network/services/samba36/patches/120-add_missing_ifdef.patch b/package/network/services/samba36/patches/120-add_missing_ifdef.patch deleted file mode 100644 index 3c0ef8ab3f..0000000000 --- a/package/network/services/samba36/patches/120-add_missing_ifdef.patch +++ /dev/null @@ -1,41 +0,0 @@ ---- a/source3/librpc/rpc/rpc_common.c -+++ b/source3/librpc/rpc/rpc_common.c -@@ -119,9 +119,11 @@ static bool initialize_interfaces(void) - if (!smb_register_ndr_interface(&ndr_table_netdfs)) { - return false; - } -+#ifdef DEVELOPER - if (!smb_register_ndr_interface(&ndr_table_rpcecho)) { - return false; - } -+#endif - if (!smb_register_ndr_interface(&ndr_table_initshutdown)) { - return false; - } ---- a/source3/rpcclient/rpcclient.c -+++ b/source3/rpcclient/rpcclient.c -@@ -628,7 +628,9 @@ static struct cmd_set *rpcclient_command - netlogon_commands, - srvsvc_commands, - dfs_commands, -+#ifdef DEVELOPER - echo_commands, -+#endif - epmapper_commands, - shutdown_commands, - test_commands, ---- a/source3/rpc_server/srv_pipe.c -+++ b/source3/rpc_server/srv_pipe.c -@@ -433,10 +433,12 @@ static bool check_bind_req(struct pipes_ - if (ok) { - context_fns->allow_connect = true; - } -+#ifdef DEVELOPER - ok = ndr_syntax_id_equal(abstract, &ndr_table_rpcecho.syntax_id); - if (ok) { - context_fns->allow_connect = true; - } -+#endif - /* - * every interface can be modified to allow "connect" auth_level by - * using a parametric option like: |