aboutsummaryrefslogtreecommitdiffstats
path: root/package/network/services/samba36/patches/010-patch-cve-2015-5252.patch
diff options
context:
space:
mode:
authorRosen Penev <rosenp@gmail.com>2019-08-31 18:50:48 -0700
committerStijn Tintel <stijn@linux-ipv6.be>2020-05-08 03:32:52 +0300
commit73fa1aba94f5cf566007ac18cee3ef08b3ae64bc (patch)
tree12d94da20915031cd34260409e6355c8e05b66b7 /package/network/services/samba36/patches/010-patch-cve-2015-5252.patch
parent79da9d78b98e1cd4574a37e2c4c5f8315b91563d (diff)
downloadupstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.tar.gz
upstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.tar.bz2
upstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.zip
samba36: Remove
Samba 3.6 is completely unsupported, in addition to having tons of patches It also causes kernel panics on some platforms when sendfile is enabled. Example: https://github.com/gnubee-git/GnuBee_Docs/issues/45 I have reproduced on ramips as well as mvebu in the past. Samba 4 is an alternative available in the packages repo. cifsd is a lightweight alternative available in the packages repo. It is also a faster alternative to both Samba versions (lower CPU usage). It was renamed to ksmbd. To summarize, here are the alternatives: - ksmbd + luci-app-cifsd - samba4 + luci-app-samba4 Signed-off-by: Rosen Penev <rosenp@gmail.com> [drop samba36-server from GEMINI_NAS_PACKAGES, ksmbd rename + summary] Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Diffstat (limited to 'package/network/services/samba36/patches/010-patch-cve-2015-5252.patch')
-rw-r--r--package/network/services/samba36/patches/010-patch-cve-2015-5252.patch39
1 files changed, 0 insertions, 39 deletions
diff --git a/package/network/services/samba36/patches/010-patch-cve-2015-5252.patch b/package/network/services/samba36/patches/010-patch-cve-2015-5252.patch
deleted file mode 100644
index 3640907a9b..0000000000
--- a/package/network/services/samba36/patches/010-patch-cve-2015-5252.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-From 2e94b6ec10f1d15e24867bab3063bb85f173406a Mon Sep 17 00:00:00 2001
-From: Jeremy Allison <jra@samba.org>
-Date: Thu, 9 Jul 2015 10:58:11 -0700
-Subject: [PATCH] CVE-2015-5252: s3: smbd: Fix symlink verification (file
- access outside the share).
-
-Ensure matching component ends in '/' or '\0'.
-
-BUG: https://bugzilla.samba.org/show_bug.cgi?id=11395
-
-Signed-off-by: Jeremy Allison <jra@samba.org>
-Reviewed-by: Volker Lendecke <vl@samba.org>
----
- source3/smbd/vfs.c | 7 +++++--
- 1 file changed, 5 insertions(+), 2 deletions(-)
-
---- a/source3/smbd/vfs.c
-+++ b/source3/smbd/vfs.c
-@@ -982,6 +982,7 @@ NTSTATUS check_reduced_name(connection_s
- if (!allow_widelinks || !allow_symlinks) {
- const char *conn_rootdir;
- size_t rootdir_len;
-+ bool matched;
-
- conn_rootdir = SMB_VFS_CONNECTPATH(conn, fname);
- if (conn_rootdir == NULL) {
-@@ -992,8 +993,10 @@ NTSTATUS check_reduced_name(connection_s
- }
-
- rootdir_len = strlen(conn_rootdir);
-- if (strncmp(conn_rootdir, resolved_name,
-- rootdir_len) != 0) {
-+ matched = (strncmp(conn_rootdir, resolved_name,
-+ rootdir_len) == 0);
-+ if (!matched || (resolved_name[rootdir_len] != '/' &&
-+ resolved_name[rootdir_len] != '\0')) {
- DEBUG(2, ("check_reduced_name: Bad access "
- "attempt: %s is a symlink outside the "
- "share path\n", fname));