diff options
| author | John Crispin <blogic@openwrt.org> | 2014-08-25 06:35:50 +0000 |
|---|---|---|
| committer | John Crispin <blogic@openwrt.org> | 2014-08-25 06:35:50 +0000 |
| commit | e723b7928ac7f10adddcb6986930a4c0f8a7ac79 (patch) | |
| tree | 9fdfe0ac58abb317b80df55e8715c220fd5b6d0c /package/network/config | |
| parent | 6c505b7533f02bcf1baf9d00d2b885cb778b5d1a (diff) | |
| download | upstream-e723b7928ac7f10adddcb6986930a4c0f8a7ac79.tar.gz upstream-e723b7928ac7f10adddcb6986930a4c0f8a7ac79.tar.bz2 upstream-e723b7928ac7f10adddcb6986930a4c0f8a7ac79.zip | |
package/*: remove useless explicit set of function returncode
somebody started to set a function returncode in the validation
stuff and everybody copies it, e.g.
myfunction()
{
fire_command
return $?
}
a function automatically returns with the last returncode,
so we can safely remove the command 'return $?'. reference:
http://tldp.org/LDP/abs/html/exit-status.html
"The last command executed in the function or script determines the exit status."
Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@42278 3c298f89-4303-0410-b956-a3cf2f4a3e73
Diffstat (limited to 'package/network/config')
| -rwxr-xr-x | package/network/config/firewall/files/firewall.init | 4 | ||||
| -rwxr-xr-x | package/network/config/netifd/files/etc/init.d/network | 14 |
2 files changed, 0 insertions, 18 deletions
diff --git a/package/network/config/firewall/files/firewall.init b/package/network/config/firewall/files/firewall.init index 662dd8010b..ee3ed1a283 100755 --- a/package/network/config/firewall/files/firewall.init +++ b/package/network/config/firewall/files/firewall.init @@ -15,8 +15,6 @@ validate_firewall_redirect() 'dest_ip:cidr' \ 'dest_port:or(port, portrange)' \ 'target:or("SNAT", "DNAT")' - - return $? } validate_firewall_rule() @@ -28,8 +26,6 @@ validate_firewall_rule() 'src_port:or(port, portrange)' \ 'dest_port:or(port, portrange)' \ 'target:string' - - return $? } service_triggers() { diff --git a/package/network/config/netifd/files/etc/init.d/network b/package/network/config/netifd/files/etc/init.d/network index 8a7427bacd..1d8a5b34ef 100755 --- a/package/network/config/netifd/files/etc/init.d/network +++ b/package/network/config/netifd/files/etc/init.d/network @@ -50,8 +50,6 @@ validate_atm_bridge_section() 'atmdev:uinteger:0' \ 'encaps:or("llc", "vc"):llc' \ 'payload:or("bridged", "routed"):bridged' - - return $? } validate_route_section() @@ -64,8 +62,6 @@ validate_route_section() 'metric:uinteger' \ 'mtu:uinteger' \ 'table:or(range(0,65535),string)' - - return $? } validate_route6_section() @@ -77,8 +73,6 @@ validate_route6_section() 'metric:uinteger' \ 'mtu:uinteger' \ 'table:or(range(0,65535),string)' - - return $? } validate_rule_section() @@ -94,8 +88,6 @@ validate_rule_section() 'lookup:or(range(0,65535),string)' \ 'goto:range(0,65535)' \ 'action:or("prohibit", "unreachable", "blackhole", "throw")' - - return $? } validate_rule6_section() @@ -111,8 +103,6 @@ validate_rule6_section() 'lookup:or(range(0,65535),string)' \ 'goto:range(0,65535)' \ 'action:or("prohibit", "unreachable", "blackhole", "throw")' - - return $? } validate_switch_section() @@ -122,8 +112,6 @@ validate_switch_section() 'enable:bool' \ 'enable_vlan:bool' \ 'reset:bool' - - return $? } validate_switch_vlan() @@ -132,8 +120,6 @@ validate_switch_vlan() 'device:string' \ 'vlan:uinteger' \ 'ports:list(ports)' - - return $? } service_triggers() |