diff options
| author | Felix Fietkau <nbd@nbd.name> | 2016-08-02 13:07:46 +0200 |
|---|---|---|
| committer | Felix Fietkau <nbd@nbd.name> | 2016-08-02 13:07:59 +0200 |
| commit | 18373e24cfa118044a23e88b4374f6a42f8002ac (patch) | |
| tree | 5f94a2272794d3a8c2bf3e7cdd8f02f82cc5780e /package/kernel | |
| parent | 349a3a127c219c82a0a906155f0edb1c5d709ee2 (diff) | |
| download | upstream-18373e24cfa118044a23e88b4374f6a42f8002ac.tar.gz upstream-18373e24cfa118044a23e88b4374f6a42f8002ac.tar.bz2 upstream-18373e24cfa118044a23e88b4374f6a42f8002ac.zip | |
ath9k: fix sta initialization bug leading to stability issues
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Diffstat (limited to 'package/kernel')
| -rw-r--r-- | package/kernel/mac80211/patches/320-ath9k-fix-using-sta-drv_priv-before-initializing-it.patch | 33 |
1 files changed, 33 insertions, 0 deletions
diff --git a/package/kernel/mac80211/patches/320-ath9k-fix-using-sta-drv_priv-before-initializing-it.patch b/package/kernel/mac80211/patches/320-ath9k-fix-using-sta-drv_priv-before-initializing-it.patch new file mode 100644 index 0000000000..aaa6706764 --- /dev/null +++ b/package/kernel/mac80211/patches/320-ath9k-fix-using-sta-drv_priv-before-initializing-it.patch @@ -0,0 +1,33 @@ +From: Felix Fietkau <nbd@nbd.name> +Date: Tue, 2 Aug 2016 13:00:01 +0200 +Subject: [PATCH] ath9k: fix using sta->drv_priv before initializing it + +A station pointer can be passed to the driver on tx, before it has been +marked as associated. Since ath9k_sta_state was initializing the entry +too late, it resulted in some spurious crashes. + +Fixes: df3c6eb34da5 ("ath9k: Use sta_state() callback") +Cc: stable@vger.kernel.org +Signed-off-by: Felix Fietkau <nbd@nbd.name> +--- + +--- a/drivers/net/wireless/ath/ath9k/main.c ++++ b/drivers/net/wireless/ath/ath9k/main.c +@@ -1563,13 +1563,13 @@ static int ath9k_sta_state(struct ieee80 + struct ath_common *common = ath9k_hw_common(sc->sc_ah); + int ret = 0; + +- if (old_state == IEEE80211_STA_AUTH && +- new_state == IEEE80211_STA_ASSOC) { ++ if (old_state == IEEE80211_STA_NOTEXIST && ++ new_state == IEEE80211_STA_NONE) { + ret = ath9k_sta_add(hw, vif, sta); + ath_dbg(common, CONFIG, + "Add station: %pM\n", sta->addr); +- } else if (old_state == IEEE80211_STA_ASSOC && +- new_state == IEEE80211_STA_AUTH) { ++ } else if (old_state == IEEE80211_STA_NONE && ++ new_state == IEEE80211_STA_NOTEXIST) { + ret = ath9k_sta_remove(hw, vif, sta); + ath_dbg(common, CONFIG, + "Remove station: %pM\n", sta->addr); |