diff options
| author | John Crispin <john@openwrt.org> | 2008-08-26 11:07:04 +0000 |
|---|---|---|
| committer | John Crispin <john@openwrt.org> | 2008-08-26 11:07:04 +0000 |
| commit | 4d7f694c438e49f1842ce9af9da778d4c884f6a9 (patch) | |
| tree | a7590ce6b54bf037843b6ecd0c2aecfcb0cdbcb1 /package/firewall | |
| parent | aa6c019c11e77e34e02fe4884016a82fa37ab5ed (diff) | |
| download | upstream-4d7f694c438e49f1842ce9af9da778d4c884f6a9.tar.gz upstream-4d7f694c438e49f1842ce9af9da778d4c884f6a9.tar.bz2 upstream-4d7f694c438e49f1842ce9af9da778d4c884f6a9.zip | |
adds more sanity checks to uci firewall
SVN-Revision: 12392
Diffstat (limited to 'package/firewall')
| -rwxr-xr-x | package/firewall/files/uci_firewall.sh | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/package/firewall/files/uci_firewall.sh b/package/firewall/files/uci_firewall.sh index e1c4d4d673..99663c6771 100755 --- a/package/firewall/files/uci_firewall.sh +++ b/package/firewall/files/uci_firewall.sh @@ -181,6 +181,8 @@ fw_rule() { [ -n "$dest" ] && TARGET=zone_${dest}_$target || TARGET=$target [ -n "$dest_port" -a -z "$proto" ] && { \ echo "dport may only be used it proto is defined"; return; } + [ -n "$src_port" -a -z "$proto" ] && { \ + echo "sport may only be used it proto is defined"; return; } $IPTABLES -I $ZONE 1 \ ${proto:+-p $proto} \ ${src_ip:+-s $src_ip} \ @@ -225,6 +227,8 @@ fw_redirect() { echo "redirect needs src and dest_ip"; return ; } [ -n "$dest_port" -a -z "$proto" ] && { \ echo "dport may only be used it proto is defined"; return; } + [ -n "$src_port" -a -z "$proto" ] && { \ + echo "sport may only be used it proto is defined"; return; } $IPTABLES -A zone_${src}_prerouting -t nat \ ${proto:+-p $proto} \ ${src_ip:+-s $src_ip} \ |