aboutsummaryrefslogtreecommitdiffstats
path: root/package/base-files/files/lib
diff options
context:
space:
mode:
authorJo-Philipp Wich <jow@openwrt.org>2010-05-30 18:23:43 +0000
committerJo-Philipp Wich <jow@openwrt.org>2010-05-30 18:23:43 +0000
commit261d41a906a8afa3d8167b091ac0b891217d8251 (patch)
treee2da46ae42921bccb65adebaf3569af27c2e93fc /package/base-files/files/lib
parent44062d09b444adeb4a481954efc43c22ebdbc65a (diff)
downloadupstream-261d41a906a8afa3d8167b091ac0b891217d8251.tar.gz
upstream-261d41a906a8afa3d8167b091ac0b891217d8251.tar.bz2
upstream-261d41a906a8afa3d8167b091ac0b891217d8251.zip
base-files: - use add_dns() and remove_dns() for when changing resolv.conf.auto for static or dhcp interfaces - force 0644 permissions when creating resolv.conf.auto, fixes dnsmasq permissions denied problem with pppd interfaces - revert dns servers in /sbin/ifdown - bump package revision
SVN-Revision: 21638
Diffstat (limited to 'package/base-files/files/lib')
-rwxr-xr-xpackage/base-files/files/lib/network/config.sh43
1 files changed, 28 insertions, 15 deletions
diff --git a/package/base-files/files/lib/network/config.sh b/package/base-files/files/lib/network/config.sh
index 32170bb274..1bb3a46ecd 100755
--- a/package/base-files/files/lib/network/config.sh
+++ b/package/base-files/files/lib/network/config.sh
@@ -70,6 +70,16 @@ add_vlan() {
add_dns() {
local cfg="$1"; shift
+ remove_dns "$cfg"
+
+ # We may be called by pppd's ip-up which has a nonstandard umask set.
+ # Create an empty file here and force its permission to 0644, otherwise
+ # dnsmasq will not be able to re-read the resolv.conf.auto .
+ [ ! -f /tmp/resolv.conf.auto ] && {
+ touch /tmp/resolv.conf.auto
+ chmod 0644 /tmp/resolv.conf.auto
+ }
+
local dns
local add
for dns in "$@"; do
@@ -79,20 +89,27 @@ add_dns() {
}
done
- uci_set_state network "$cfg" dns "$add"
+ [ -n "$cfg" ] && {
+ uci_set_state network "$cfg" dns "$add"
+ uci_set_state network "$cfg" resolv_dns "$add"
+ }
}
# remove dns entries of the given iface
remove_dns() {
local cfg="$1"
- local dns
- config_get dns "$cfg" dns
- for dns in $dns; do
- sed -i -e "/^nameserver $dns$/d" /tmp/resolv.conf.auto
- done
+ [ -n "$cfg" ] && {
+ [ -f /tmp/resolv.conf.auto ] && {
+ local dns=$(uci_get_state network "$cfg" resolv_dns)
+ for dns in $dns; do
+ sed -i -e "/^nameserver $dns$/d" /tmp/resolv.conf.auto
+ done
+ }
- uci_revert_state network "$cfg" dns
+ uci_revert_state network "$cfg" dns
+ uci_revert_state network "$cfg" resolv_dns
+ }
}
# sort the device list, drop duplicates
@@ -212,13 +229,7 @@ setup_interface_static() {
[ -z "$ip6addr" ] || $DEBUG ifconfig "$iface" add "$ip6addr"
[ -z "$gateway" ] || $DEBUG route add default gw "$gateway" dev "$iface"
[ -z "$ip6gw" ] || $DEBUG route -A inet6 add default gw "$ip6gw" dev "$iface"
- [ -z "$dns" ] || {
- for ns in $dns; do
- grep "$ns" /tmp/resolv.conf.auto 2>/dev/null >/dev/null || {
- echo "nameserver $ns" >> /tmp/resolv.conf.auto
- }
- done
- }
+ [ -z "$dns" ] || add_dns "$config" $dns
config_get type "$config" TYPE
[ "$type" = "alias" ] && return 0
@@ -363,12 +374,14 @@ setup_interface() {
stop_interface_dhcp() {
local config="$1"
- local iface
+ local ifname
config_get ifname "$config" ifname
local lock="/var/lock/dhcp-${ifname}"
[ -f "$lock" ] && lock -u "$lock"
+ remove_dns "$config"
+
local pidfile="/var/run/dhcp-${ifname}.pid"
local pid="$(cat "$pidfile" 2>/dev/null)"
[ -d "/proc/$pid" ] && {