diff options
| author | Felix Fietkau <nbd@openwrt.org> | 2007-02-18 13:52:14 +0000 |
|---|---|---|
| committer | Felix Fietkau <nbd@openwrt.org> | 2007-02-18 13:52:14 +0000 |
| commit | 660cc6c6cc64149cfbe1fea4893df607207df597 (patch) | |
| tree | 5a537257117b5d6a0af901cf3fe966100addd352 /include/image.mk | |
| parent | 2b9b7b12721d02d45c36c954512a5000e72273a3 (diff) | |
| download | upstream-660cc6c6cc64149cfbe1fea4893df607207df597.tar.gz upstream-660cc6c6cc64149cfbe1fea4893df607207df597.tar.bz2 upstream-660cc6c6cc64149cfbe1fea4893df607207df597.zip | |
Finally fix the pesky x86-2.6 block2mtd related crash (#1058)
When erasing blocks, block2mtd checks the block on the physical disk
to see if everything's filled with 0xff. When grabbing a page from the page
cache, it initializes the limit as <start address> + PAGE_SIZE.
Turns out that the pointer to the status page is (unsigned long *), and
thus it adds (PAGE_SIZE * 4).
This would never have been caught, if it wasn't for the unlikely event
that block2mtd catches the *last* page available in the system ram and
thus tries to scan 4 memory pages from there.
The absolutely trivial fix is to do a double cast (cast to (u8 *), add
PAGE_SIZE, then cast to (unsigned long *))
... and there was much rejoicing
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@6318 3c298f89-4303-0410-b956-a3cf2f4a3e73
Diffstat (limited to 'include/image.mk')
0 files changed, 0 insertions, 0 deletions