aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Hoffmann <jan@3e8.eu>2022-12-17 21:45:41 +0100
committerSander Vanheule <sander@svanheule.net>2022-12-27 16:29:57 +0100
commit9aa123d778e2631c2698a60ceeec610a14e1343b (patch)
tree5af511bf5b8b6e920dead86568eb7642177b043f
parentc94ca63ed4eed9aa92dc2fa4d61235b6845b42d3 (diff)
downloadupstream-9aa123d778e2631c2698a60ceeec610a14e1343b.tar.gz
upstream-9aa123d778e2631c2698a60ceeec610a14e1343b.tar.bz2
upstream-9aa123d778e2631c2698a60ceeec610a14e1343b.zip
realtek: simplify log messages in rtl83xx_mdio_probe
This function currently prints three messages for every switch port at KERN_INFO level. This takes a considerable amount of time during bootup and can even trigger an external watchdog. Replace these log messages by a single one at KERN_DEBUG level. Signed-off-by: Jan Hoffmann <jan@3e8.eu>
-rw-r--r--target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c8
-rw-r--r--target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/common.c8
2 files changed, 2 insertions, 14 deletions
diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c
index e86ff9ccdf..63c024c81e 100644
--- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c
+++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c
@@ -323,7 +323,6 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv)
if (of_property_read_u32(dn, "reg", &pn))
continue;
- pr_info("%s found port %d\n", __func__, pn);
phy_node = of_parse_phandle(dn, "phy-handle", 0);
if (!phy_node) {
if (pn != priv->cpu_port)
@@ -331,14 +330,9 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv)
continue;
}
- pr_info("%s port %d has phandle\n", __func__, pn);
if (of_property_read_u32(phy_node, "sds", &priv->ports[pn].sds_num))
priv->ports[pn].sds_num = -1;
- else {
- pr_info("%s sds port %d is %d\n", __func__, pn,
- priv->ports[pn].sds_num);
- }
- pr_info("%s port %d has SDS\n", __func__, priv->ports[pn].sds_num);
+ pr_debug("%s port %d has SDS %d\n", __func__, pn, priv->ports[pn].sds_num);
if (of_get_phy_mode(dn, &interface))
interface = PHY_INTERFACE_MODE_NA;
diff --git a/target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/common.c b/target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/common.c
index b5afed0ef5..8b0b55d891 100644
--- a/target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/common.c
+++ b/target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/common.c
@@ -323,7 +323,6 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv)
if (of_property_read_u32(dn, "reg", &pn))
continue;
- pr_info("%s found port %d\n", __func__, pn);
phy_node = of_parse_phandle(dn, "phy-handle", 0);
if (!phy_node) {
if (pn != priv->cpu_port)
@@ -331,14 +330,9 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv)
continue;
}
- pr_info("%s port %d has phandle\n", __func__, pn);
if (of_property_read_u32(phy_node, "sds", &priv->ports[pn].sds_num))
priv->ports[pn].sds_num = -1;
- else {
- pr_info("%s sds port %d is %d\n", __func__, pn,
- priv->ports[pn].sds_num);
- }
- pr_info("%s port %d has SDS\n", __func__, priv->ports[pn].sds_num);
+ pr_debug("%s port %d has SDS %d\n", __func__, pn, priv->ports[pn].sds_num);
if (of_get_phy_mode(dn, &interface))
interface = PHY_INTERFACE_MODE_NA;