diff options
| author | Hauke Mehrtens <hauke@hauke-m.de> | 2022-03-31 18:43:09 +0200 |
|---|---|---|
| committer | Hauke Mehrtens <hauke@hauke-m.de> | 2022-04-05 23:33:16 +0200 |
| commit | d18e365b17d1c247cffcc1686d66c88b74d3446c (patch) | |
| tree | c9526749ab5a14cd8c479ce00fcbc0829ee674f6 | |
| parent | 9d2b26d5a70583c0cc0bcb94d7e0fb6ac498069a (diff) | |
| download | upstream-d18e365b17d1c247cffcc1686d66c88b74d3446c.tar.gz upstream-d18e365b17d1c247cffcc1686d66c88b74d3446c.tar.bz2 upstream-d18e365b17d1c247cffcc1686d66c88b74d3446c.zip | |
busybox: Fix snprintf arguments in lock
The first argument for snprintf is the buffer and the 2. one is the
size. Fix the order. This broke the lock application.
Fixes: 9d2b26d5a705 ("busybox: fix busybox lock applet pidstr buffer overflow")
Reported-by: Hartmut Birr <e9hack@gmail.com>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit d80336e1a970b088c235dcf2773052537e6f5d72)
| -rw-r--r-- | package/utils/busybox/patches/220-add_lock_util.patch | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/package/utils/busybox/patches/220-add_lock_util.patch b/package/utils/busybox/patches/220-add_lock_util.patch index 623121b9fb..579b705f34 100644 --- a/package/utils/busybox/patches/220-add_lock_util.patch +++ b/package/utils/busybox/patches/220-add_lock_util.patch @@ -109,7 +109,7 @@ + if (!waitonly) { + lseek(fd, 0, SEEK_SET); + ftruncate(fd, 0); -+ snprintf(sizeof(pidstr), pidstr, "%d\n", pid); ++ snprintf(pidstr, sizeof(pidstr), "%d\n", pid); + write(fd, pidstr, strlen(pidstr)); + close(fd); + } |