diff options
| author | Daniel Dickinson <crazycshore@gmail.com> | 2010-11-15 04:08:09 +0000 |
|---|---|---|
| committer | Daniel Dickinson <crazycshore@gmail.com> | 2010-11-15 04:08:09 +0000 |
| commit | 6cd4575153871296a1596dc9c27cd820f65b6ecc (patch) | |
| tree | fad2b7212f04df0dc6d2d40b492d3ff04996037f | |
| parent | 5bf3838a00e7946b2ce50a5c849f9bb270a185be (diff) | |
| download | upstream-6cd4575153871296a1596dc9c27cd820f65b6ecc.tar.gz upstream-6cd4575153871296a1596dc9c27cd820f65b6ecc.tar.bz2 upstream-6cd4575153871296a1596dc9c27cd820f65b6ecc.zip | |
brcm63xx: imagetag: Fixed occaisonal wrong CRC in image due to using strncpy to copy the CRC into the imagetag. strncpy stops copying after a 00 byte, memcpy doesn't.
SVN-Revision: 24000
| -rw-r--r-- | tools/firmware-utils/src/imagetag.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/firmware-utils/src/imagetag.c b/tools/firmware-utils/src/imagetag.c index 1fb45e9e95..0ecbada284 100644 --- a/tools/firmware-utils/src/imagetag.c +++ b/tools/firmware-utils/src/imagetag.c @@ -32,9 +32,9 @@ union int2char { char output[4]; }; -/* This appears to be necessary due to alignment issues */ +/* Convert uint32_t CRC to bigendian and copy it into a character array */ #define int2tag(tag, value) intchar.input = htonl(value); \ - strncpy(tag, intchar.output, sizeof(union int2char)) + memcpy(tag, intchar.output, sizeof(union int2char)) /* Kernel header */ struct kernelhdr { |