diff options
| author | John Crispin <john@openwrt.org> | 2013-12-27 21:15:31 +0000 |
|---|---|---|
| committer | John Crispin <john@openwrt.org> | 2013-12-27 21:15:31 +0000 |
| commit | 3b4152bfda495105fac86c36bc791ccdb91ea142 (patch) | |
| tree | 7f1e7a2e27c68f88f85da1c082f6334081382d30 | |
| parent | d1156bca0a2e3981aad62d6cc9155f71c01c3915 (diff) | |
| download | upstream-3b4152bfda495105fac86c36bc791ccdb91ea142.tar.gz upstream-3b4152bfda495105fac86c36bc791ccdb91ea142.tar.bz2 upstream-3b4152bfda495105fac86c36bc791ccdb91ea142.zip | |
firmware-utils: check_magic() in buffalo-lib.c always return 0
spotted with cppcheck
Signed-off-by: Etienne CHAMPETIER <etienne.champetier@free.fr>
SVN-Revision: 39171
| -rw-r--r-- | tools/firmware-utils/src/buffalo-lib.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/firmware-utils/src/buffalo-lib.c b/tools/firmware-utils/src/buffalo-lib.c index 29aee9f88d..add3a7e023 100644 --- a/tools/firmware-utils/src/buffalo-lib.c +++ b/tools/firmware-utils/src/buffalo-lib.c @@ -249,10 +249,10 @@ static uint32_t get_be32(void *data) static int check_magic(void *magic) { - if (!memcmp("start", magic, ENC_MAGIC_LEN)); + if (!memcmp("start", magic, ENC_MAGIC_LEN)) return 0; - if (!memcmp("asar1", magic, ENC_MAGIC_LEN)); + if (!memcmp("asar1", magic, ENC_MAGIC_LEN)) return 0; return -1; |