aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Schiffer <mschiffer@universe-factory.net>2018-01-04 17:18:16 +0100
committerMatthias Schiffer <mschiffer@universe-factory.net>2018-01-04 17:18:16 +0100
commit0b28cc56d4352f5a8b2e7783d3787e6effcdb630 (patch)
tree93a47f2f9ff2900eb1d1f576518fcc03cd297895
parentda95c9aa17814d691a7fed6e8297fb29c5600c27 (diff)
downloadupstream-0b28cc56d4352f5a8b2e7783d3787e6effcdb630.tar.gz
upstream-0b28cc56d4352f5a8b2e7783d3787e6effcdb630.tar.bz2
upstream-0b28cc56d4352f5a8b2e7783d3787e6effcdb630.zip
scripts/package-metadata.pl: remove broken detection of self-dependencies
A self-dependency is not an error worth a warning; rather, it is very common: whenever there are dependencies between different binary packages originating from the same source package, such dependencies occur. Not actually generating dependency rules is correct, but already handled a few lines below. A typo prevented this redundant rule from working, which is the reason the warning was not actually printed. Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
-rwxr-xr-xscripts/package-metadata.pl5
1 files changed, 0 insertions, 5 deletions
diff --git a/scripts/package-metadata.pl b/scripts/package-metadata.pl
index 261490b868..fbd458bf2a 100755
--- a/scripts/package-metadata.pl
+++ b/scripts/package-metadata.pl
@@ -535,11 +535,6 @@ sub gen_package_mk() {
$pkg->{makefile}, $pkg_dep->{src}, $deptype, $pkg_dep->{makefile}, $deptype;
next;
}
- unless ($pkg->{src} ne $pkg_dep->{sec}.$suffix) {
- warn sprintf "WARNING: Makefile '%s' has a build dependency on itself\n",
- $pkg->{makefile};
- next;
- }
$idx = $pkg_dep->{subdir}.$pkg_dep->{src};
} elsif (defined($srcpackage{$dep})) {
$idx = $subdir{$dep}.$dep;