aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelix Fietkau <nbd@openwrt.org>2009-11-07 17:40:52 +0000
committerFelix Fietkau <nbd@openwrt.org>2009-11-07 17:40:52 +0000
commitae0457f76a2a1e67cd0231e978c19911fe386064 (patch)
tree490d856f89871be3b4d902366b55c7942d212d95
parent2e72f3b26934dbebf8793dfb7c32b33d3e780fde (diff)
downloadupstream-ae0457f76a2a1e67cd0231e978c19911fe386064.tar.gz
upstream-ae0457f76a2a1e67cd0231e978c19911fe386064.tar.bz2
upstream-ae0457f76a2a1e67cd0231e978c19911fe386064.zip
b43: work around a locking issue, might fix #5996
SVN-Revision: 18338
-rw-r--r--package/mac80211/patches/405-b43_locking_fix.patch23
1 files changed, 23 insertions, 0 deletions
diff --git a/package/mac80211/patches/405-b43_locking_fix.patch b/package/mac80211/patches/405-b43_locking_fix.patch
new file mode 100644
index 0000000000..c90890a7a7
--- /dev/null
+++ b/package/mac80211/patches/405-b43_locking_fix.patch
@@ -0,0 +1,23 @@
+Subject: [PATCH] b43: work around a locking issue in ->set_tim()
+
+ops->set_tim() must be atomic, so b43 trying to acquire a mutex leads
+to a kernel crash. This patch trades an easy to trigger crash in AP
+mode for an unlikely race condition. According to Michael, the real
+fix would be to allow set_tim() callbacks to sleep, since b43 is
+not the only driver that needs to sleep in all callbacks.
+
+Signed-off-by: Felix Fietkau <nbd@openwrt.org>
+
+--- a/drivers/net/wireless/b43/main.c
++++ b/drivers/net/wireless/b43/main.c
+@@ -4534,9 +4534,8 @@ static int b43_op_beacon_set_tim(struct
+ {
+ struct b43_wl *wl = hw_to_b43_wl(hw);
+
+- mutex_lock(&wl->mutex);
++ /* FIXME: add locking */
+ b43_update_templates(wl);
+- mutex_unlock(&wl->mutex);
+
+ return 0;
+ }