aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGabor Juhos <juhosg@openwrt.org>2010-01-20 09:30:32 +0000
committerGabor Juhos <juhosg@openwrt.org>2010-01-20 09:30:32 +0000
commit0d48b043b1540a6f12a5319133ac98f5c43a42fb (patch)
treeb5d988b63a7f62f978f42edd063b9f854832bfec
parent0296b24f804941dcde569223db0ed5660c90e0fc (diff)
downloadupstream-0d48b043b1540a6f12a5319133ac98f5c43a42fb.tar.gz
upstream-0d48b043b1540a6f12a5319133ac98f5c43a42fb.tar.bz2
upstream-0d48b043b1540a6f12a5319133ac98f5c43a42fb.zip
rtl8366_smi: fix error checking in rtl8366s_set_vlan_4k_entry
SVN-Revision: 19242
-rw-r--r--target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c b/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
index 46069067e7..1043b3d44e 100644
--- a/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
+++ b/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
@@ -671,16 +671,16 @@ static int rtl8366s_set_vlan_4k_entry(struct rtl8366_smi *smi,
data = *tableaddr;
- rtl8366_smi_write_reg(smi, RTL8366S_VLAN_TABLE_WRITE_BASE + 1, data);
-
+ err = rtl8366_smi_write_reg(smi, RTL8366S_VLAN_TABLE_WRITE_BASE + 1,
+ data);
+ if (err)
+ return err;
/* write table access control word */
err = rtl8366_smi_write_reg(smi, RTL8366S_TABLE_ACCESS_CTRL_REG,
RTL8366S_TABLE_VLAN_WRITE_CTRL);
- if (err)
- return err;
- return 0;
+ return err;
}
static int rtl8366s_get_vlan_member_config(struct rtl8366_smi *smi, u32 index,