aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafał Miłecki <zajec5@gmail.com>2015-04-14 12:18:57 +0000
committerRafał Miłecki <zajec5@gmail.com>2015-04-14 12:18:57 +0000
commit834e60c4f16b3131c9dd51a0bc00bd47222f57a6 (patch)
tree2219917cde9d14d1de16fe0bf7a8abec1f5b1f5e
parentb5073ca2c859fe8763a0717abcfb5f5646d5a543 (diff)
downloadupstream-834e60c4f16b3131c9dd51a0bc00bd47222f57a6.tar.gz
upstream-834e60c4f16b3131c9dd51a0bc00bd47222f57a6.tar.bz2
upstream-834e60c4f16b3131c9dd51a0bc00bd47222f57a6.zip
otrx: check TRX length read from header to avoid Segmentation fault
Signed-off-by: Rafał Miłecki <zajec5@gmail.com> SVN-Revision: 45433
-rw-r--r--package/utils/otrx/src/otrx.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/package/utils/otrx/src/otrx.c b/package/utils/otrx/src/otrx.c
index a2bc29f59a..7fe4ba6f69 100644
--- a/package/utils/otrx/src/otrx.c
+++ b/package/utils/otrx/src/otrx.c
@@ -167,6 +167,12 @@ static int otrx_check() {
}
length = le32_to_cpu(hdr.length);
+ if (length < sizeof(hdr)) {
+ fprintf(stderr, "Length read from TRX too low (%zu B)\n", length);
+ err = -EINVAL;
+ goto err_close;
+ }
+
buf = malloc(length);
if (!buf) {
fprintf(stderr, "Couldn't alloc %d B buffer\n", length);