From 716ca530e1c4515d8683c9d5be3d56b301758b66 Mon Sep 17 00:00:00 2001 From: James <> Date: Wed, 4 Nov 2015 11:49:21 +0000 Subject: trunk-47381 --- ...-fix-kbuild-compile-warnings-errors-and-a.patch | 56 ++++++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 target/linux/brcm2708/patches-4.1/0157-spi-bcm2835-fix-kbuild-compile-warnings-errors-and-a.patch (limited to 'target/linux/brcm2708/patches-4.1/0157-spi-bcm2835-fix-kbuild-compile-warnings-errors-and-a.patch') diff --git a/target/linux/brcm2708/patches-4.1/0157-spi-bcm2835-fix-kbuild-compile-warnings-errors-and-a.patch b/target/linux/brcm2708/patches-4.1/0157-spi-bcm2835-fix-kbuild-compile-warnings-errors-and-a.patch new file mode 100644 index 0000000..f51f352 --- /dev/null +++ b/target/linux/brcm2708/patches-4.1/0157-spi-bcm2835-fix-kbuild-compile-warnings-errors-and-a.patch @@ -0,0 +1,56 @@ +From 3ab28d3476f08708cf2c256dd8a9871583edea00 Mon Sep 17 00:00:00 2001 +From: Martin Sperl +Date: Tue, 12 May 2015 10:32:08 +0000 +Subject: [PATCH 157/203] spi: bcm2835: fix kbuild compile warnings/errors and + a typo + +fixes several warnings/error emmitted by the kbuild system: +* warn: cast from pointer to integer of different size + using size_t instead of u32 +* error: 'SZ_4K' undeclared + moved to PAGE_SIZE and PAGE_MASK instead + +Review showed also a typo in the same code where tx_buff +was checked twice instead of checking both rx and tx_buff. + +Reported by: Stephen Rothwell +Signed-off-by: Martin Sperl +Signed-off-by: Mark Brown +(cherry picked from commit 7e52be0d576e8f7bc99a606f07b9d000c4340f04) +--- + drivers/spi/spi-bcm2835.c | 8 +++++--- + 1 file changed, 5 insertions(+), 3 deletions(-) + +--- a/drivers/spi/spi-bcm2835.c ++++ b/drivers/spi/spi-bcm2835.c +@@ -20,6 +20,7 @@ + * GNU General Public License for more details. + */ + ++#include + #include + #include + #include +@@ -378,18 +379,19 @@ static bool bcm2835_spi_can_dma(struct s + } + + /* if we run rx/tx_buf with word aligned addresses then we are OK */ +- if (((u32)tfr->tx_buf % 4 == 0) && ((u32)tfr->tx_buf % 4 == 0)) ++ if ((((size_t)tfr->rx_buf & 3) == 0) && ++ (((size_t)tfr->tx_buf & 3) == 0)) + return true; + + /* otherwise we only allow transfers within the same page + * to avoid wasting time on dma_mapping when it is not practical + */ +- if (((u32)tfr->tx_buf % SZ_4K) + tfr->len > SZ_4K) { ++ if (((size_t)tfr->tx_buf & PAGE_MASK) + tfr->len > PAGE_SIZE) { + dev_warn_once(&spi->dev, + "Unaligned spi tx-transfer bridging page\n"); + return false; + } +- if (((u32)tfr->rx_buf % SZ_4K) + tfr->len > SZ_4K) { ++ if (((size_t)tfr->rx_buf & PAGE_MASK) + tfr->len > PAGE_SIZE) { + dev_warn_once(&spi->dev, + "Unaligned spi tx-transfer bridging page\n"); + return false; -- cgit v1.2.3