diff options
| author | John Crispin <john@openwrt.org> | 2014-06-02 12:43:22 +0000 |
|---|---|---|
| committer | John Crispin <john@openwrt.org> | 2014-06-02 12:43:22 +0000 |
| commit | f933a741a9c44cea58b2b3837dca99fc55d0b957 (patch) | |
| tree | b87ca90d9e7b0432bfda4c69a8fef02d08f8e748 /target/linux/ixp4xx | |
| parent | a866b7eb9d45ecb986c275cbd2033322b54d2606 (diff) | |
| download | master-31e0f0ae-f933a741a9c44cea58b2b3837dca99fc55d0b957.tar.gz master-31e0f0ae-f933a741a9c44cea58b2b3837dca99fc55d0b957.tar.bz2 master-31e0f0ae-f933a741a9c44cea58b2b3837dca99fc55d0b957.zip | |
target/linux/*/base-files/lib/upgrade/platform.sh - wrong check for ARGC
ARGC is a 'C-ism', but not known/valid in shell-syntax - insert the correct
var $# (=number of args) here. under normal conditions this had no impact,
but we should at least correct it. the error was observable like this:
root@box:~ [ -e "/etc/functions.sh" ] && . /etc/functions.sh
root@box:~ [ -e "/lib/functions.sh" ] && . /lib/functions.sh
root@box:~ . /lib/upgrade/platform.sh
root@box:~ . /lib/upgrade/common.sh
root@box:~ platform_check_image /tmp/myfirmware.bin
ash: bad number
root@box:~ echo $?
0
Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>
SVN-Revision: 40915
Diffstat (limited to 'target/linux/ixp4xx')
| -rw-r--r-- | target/linux/ixp4xx/base-files/lib/upgrade/platform.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/linux/ixp4xx/base-files/lib/upgrade/platform.sh b/target/linux/ixp4xx/base-files/lib/upgrade/platform.sh index d10d934370..508a167419 100644 --- a/target/linux/ixp4xx/base-files/lib/upgrade/platform.sh +++ b/target/linux/ixp4xx/base-files/lib/upgrade/platform.sh @@ -93,7 +93,7 @@ platform_check_image() { local kern_part_size=0x$(platform_find_part_size "$kernelpart") local kern_length=0x$(dd if="$1" bs=2 skip=1 count=4 2>/dev/null) - [ "$ARGC" -gt 1 ] && return 1 + [ "$#" -gt 1 ] && return 1 case "$board" in avila | cambria ) |