diff options
| author | John Crispin <john@openwrt.org> | 2014-10-14 12:21:11 +0000 |
|---|---|---|
| committer | John Crispin <john@openwrt.org> | 2014-10-14 12:21:11 +0000 |
| commit | 20940138ac41e3eca54afefc34f65e40834be3ea (patch) | |
| tree | 3c34846e48daad4595ab2ab2c00f1068022ee62f /package/base-files/files/sbin | |
| parent | 8267c0e2ac371fe0f93ba34f745976acf358a253 (diff) | |
| download | master-31e0f0ae-20940138ac41e3eca54afefc34f65e40834be3ea.tar.gz master-31e0f0ae-20940138ac41e3eca54afefc34f65e40834be3ea.tar.bz2 master-31e0f0ae-20940138ac41e3eca54afefc34f65e40834be3ea.zip | |
scripts: fix wrong usage of '==' operator
[base-files] shell-scripting: fix wrong usage of '==' operator
normally the '==' is used for invoking a regex parser and is a bashism.
all of the fixes just want to compare a string. the used busybox-ash
will silently "ignore" this mistake, but make it portable/clean at least.
this patch does not change the behavior/logic of the scripts.
Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>
SVN-Revision: 42911
Diffstat (limited to 'package/base-files/files/sbin')
| -rwxr-xr-x | package/base-files/files/sbin/led.sh | 6 | ||||
| -rwxr-xr-x | package/base-files/files/sbin/wifi | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/package/base-files/files/sbin/led.sh b/package/base-files/files/sbin/led.sh index d67a0f51cc..d750f06ea7 100755 --- a/package/base-files/files/sbin/led.sh +++ b/package/base-files/files/sbin/led.sh @@ -9,15 +9,15 @@ do_led() { local sysfs config_get name $1 name config_get sysfs $1 sysfs - [ "$name" == "$NAME" -o "$sysfs" = "$NAME" -a -e "/sys/class/leds/${sysfs}" ] && { - [ "$ACTION" == "set" ] && + [ "$name" = "$NAME" -o "$sysfs" = "$NAME" -a -e "/sys/class/leds/${sysfs}" ] && { + [ "$ACTION" = "set" ] && echo 1 >/sys/class/leds/${sysfs}/brightness \ || echo 0 >/sys/class/leds/${sysfs}/brightness exit 0 } } -[ "$1" == "clear" -o "$1" == "set" ] && +[ "$1" = "clear" -o "$1" = "set" ] && [ -n "$2" ] &&{ config_load system config_foreach do_led diff --git a/package/base-files/files/sbin/wifi b/package/base-files/files/sbin/wifi index 051bc89a2d..2476414337 100755 --- a/package/base-files/files/sbin/wifi +++ b/package/base-files/files/sbin/wifi @@ -108,7 +108,7 @@ wifi_fixup_hwmode() { _wifi_updown() { for device in ${2:-$DEVICES}; do ( config_get disabled "$device" disabled - [ 1 == "$disabled" ] && { + [ "$disabled" = "1" ] && { echo "'$device' is disabled" set disable } |